From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: minimal tcl version for gdb test suite
Date: Thu, 01 Aug 2019 09:39:00 -0000 [thread overview]
Message-ID: <cfc6b014-45cf-7fc0-4ce2-80ec34c6f460@suse.de> (raw)
In-Reply-To: <87k1byhzar.fsf@tromey.com>
On 31-07-19 19:46, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
>>> + _insert [string repeat " " $n]
>
> Tom> I noticed you started using "string repeat", available since tcl 8.3.
>
> Tom> So, I was wondering ... is there a minimal required tcl version for the
> Tom> gdb testsuite? If so, is it documented somewhere?
>
> Thanks for the note. FWIW I didn't "upgrade" gdb intentionally. We can
> remove this use if need be.
>
> I don't know whether there is a minimum version.
> According to https://www.tcl.tk/software/tcltk/8.3.html, Tcl 8.3.5 was
> released on Oct 18, 2002. So, it is 17 years old.
>
> Of course, the standard isn't date-based -- it's based on what the
> distros do. I don't have a super way to check that though.
>
Ok, I see. I guess then we operate on a "it's fine if nobody complains"
basis.
I've just committed a patch (
https://sourceware.org/ml/gdb-patches/2019-08/msg00003.html ) that uses
lrepeat. This was added in tcl 8.5, so I've added an lrepeat version in
gdb.exp for older versions, just in case.
FWIW:
- I found a commit message (75312ae3ab) mentioning something about mingw
using tcl 8.4
- We've also got lrepeat, which was added in 2012 for backward
compatibility with tcl pre-7.5.
Thanks,
- Tom
next prev parent reply other threads:[~2019-08-01 9:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 18:51 [PATCH v2 0/8] TUI testing Tom Tromey
2019-07-26 18:51 ` [PATCH v2 3/8] Add "layout split" test Tom Tromey
2019-07-26 18:51 ` [PATCH v2 6/8] Add TUI resizing test Tom Tromey
2019-07-26 18:51 ` [PATCH v2 1/8] A virtual terminal for the test suite Tom Tromey
2019-07-27 16:01 ` Andrew Burgess
2019-07-28 2:56 ` Tom Tromey
2019-07-31 15:44 ` minimal tcl version for gdb " Tom de Vries
2019-07-31 17:46 ` Tom Tromey
2019-08-01 9:39 ` Tom de Vries [this message]
2019-08-01 15:48 ` Tom Tromey
2019-07-26 18:51 ` [PATCH v2 4/8] Add TUI register window test Tom Tromey
2019-07-26 18:51 ` [PATCH v2 5/8] Add TUI test for "list" Tom Tromey
2019-07-26 18:51 ` [PATCH v2 7/8] Add test case for empty TUI windows Tom Tromey
2019-07-26 18:51 ` [PATCH v2 8/8] Add test that "file" shows "main" Tom Tromey
2019-07-26 18:51 ` [PATCH v2 2/8] Add test for "layout asm" Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfc6b014-45cf-7fc0-4ce2-80ec34c6f460@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox