From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51120 invoked by alias); 1 Aug 2019 09:39:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51111 invoked by uid 89); 1 Aug 2019 09:39:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.2 required=5.0 tests=AWL,BAYES_00,KAM_SHORT,KAM_TK,SPF_PASS autolearn=no version=3.3.1 spammy=UD:tk, Weve, We've, Oct X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Aug 2019 09:39:38 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 67E44B65A; Thu, 1 Aug 2019 09:39:36 +0000 (UTC) Subject: Re: minimal tcl version for gdb test suite To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20190726185134.1856-1-tom@tromey.com> <20190726185134.1856-2-tom@tromey.com> <87k1byhzar.fsf@tromey.com> From: Tom de Vries Openpgp: preference=signencrypt Message-ID: Date: Thu, 01 Aug 2019 09:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <87k1byhzar.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00005.txt.bz2 On 31-07-19 19:46, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > >>> + _insert [string repeat " " $n] > > Tom> I noticed you started using "string repeat", available since tcl 8.3. > > Tom> So, I was wondering ... is there a minimal required tcl version for the > Tom> gdb testsuite? If so, is it documented somewhere? > > Thanks for the note. FWIW I didn't "upgrade" gdb intentionally. We can > remove this use if need be. > > I don't know whether there is a minimum version. > According to https://www.tcl.tk/software/tcltk/8.3.html, Tcl 8.3.5 was > released on Oct 18, 2002. So, it is 17 years old. > > Of course, the standard isn't date-based -- it's based on what the > distros do. I don't have a super way to check that though. > Ok, I see. I guess then we operate on a "it's fine if nobody complains" basis. I've just committed a patch ( https://sourceware.org/ml/gdb-patches/2019-08/msg00003.html ) that uses lrepeat. This was added in tcl 8.5, so I've added an lrepeat version in gdb.exp for older versions, just in case. FWIW: - I found a commit message (75312ae3ab) mentioning something about mingw using tcl 8.4 - We've also got lrepeat, which was added in 2012 for backward compatibility with tcl pre-7.5. Thanks, - Tom