Re: [PATCH v1] gdb: Fix assignment to TYPE_CODE_FLAGS registers

[Simon Marchi <simark@simark.ca>]

On 7/13/26 5:11 AM, srinath.parvathaneni@arm.com wrote:
> From: Srinath Parvathaneni <srinath.parvathaneni@arm.com>
> 
> GDB reports "Invalid cast" when assigning small integer literals (32-bit) to
> 64-bit TYPE_CODE_FLAGS registers. For example, with the existing upstream FPMR
> register, set $fpmr = 0x777777777 succeeds, whereas set $fpmr = 0x77 fails with
> "Invalid cast" and this patch fixes the issue but makes changes to a generic
> function value_cast in gdb/valops.c.
> 
>         * testsuite/gdb.arch/aarch64-fpmr.exp : Add "set $fpmr" test.
>         * gdb/valops.c (value_cast): Add TYPE_CODE_FLAGS condition to integer
> 	assignment.
> 
> Regression tested on aarch64-none-linux-gnu with no regressions.
> 
> Ok for GDB master?

This seems fine to me, but I am not as confident with this value_cast
code as I am with other things, so I'll give you the:

Approved-By: Simon Marchi <simon.marchi@efficios.com>

but wait ~1 week before pushing in case someone sees something I don't.

Simon