From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mTd4NZfZVGq7HwYAWB0awg (envelope-from ) for ; Mon, 13 Jul 2026 08:27:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1783945623; bh=MT3ivGDOTKYz5SNuppN/ZhJ97YOrAjb8TjJ3Z4AZ684=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=CdQktAMtFgtti7OkDrQfC7463IaC6Jk6i/+lY9X0aSwC1L8EeIswOFoYI+EPi0asI SyIGqJZEp3GMJla8+mCUjc7aTwgHA5KoN88iI7LkbngrUUCThAyfnJ0n7qSmyBAL09 Tom921ODVZgEsYYPdxDP6qFYUkWHjLBokzs/Oy5Q= Received: by simark.ca (Postfix, from userid 112) id D74171E09B; Mon, 13 Jul 2026 08:27:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=lvVTy1pZ; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 60F571E033 for ; Mon, 13 Jul 2026 08:27:03 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B2B6B4BA2E3C for ; Mon, 13 Jul 2026 12:26:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B2B6B4BA2E3C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=lvVTy1pZ Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id EAFE84BA2E07 for ; Mon, 13 Jul 2026 12:26:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EAFE84BA2E07 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EAFE84BA2E07 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783945592; cv=none; b=T8tnRopDe/t8ySJ+9s9jTPAeVX3KU3ccGR74UJTdxYqBDBJffAXAGgFVDe0IEIKTKUhrjrJx1zUW+WQ4gH5DF2SxTmMbhQhdZGOFBUDXYsZljhCDy45D4klgPVoJXL+w3NtQDNsSNZyGiFH1d7YQSA8zxcoU16d4UigMgQs3xmk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783945592; c=relaxed/simple; bh=MT3ivGDOTKYz5SNuppN/ZhJ97YOrAjb8TjJ3Z4AZ684=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=mZIdBM5ObUHSq5xkuCwsMmHoKsiH1jWLRp+6xlE/ksUw/vxgrZJYc4XB7U4LREemIM8LBcwky53199iCII4ZZIwoW9xxiCQ+luPjprsNXb5MI4+11St3pMy3VzCLp2B4rgRAd/Q+YUZchbuSKv5UGreXpmQWFqmr+PTTANgaL+U= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=lvVTy1pZ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EAFE84BA2E07 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1783945591; bh=MT3ivGDOTKYz5SNuppN/ZhJ97YOrAjb8TjJ3Z4AZ684=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=lvVTy1pZUTkbwfVCSRwU1R7nzfAGUrI+Ux/TsRMgglu79dErpRiiD+Pn8+ugZIVqD 3EopS8AAm0o5hEJQTFDOU2KA4W6mPWEkLB2uOB49vjd0sPOWjG3MjeA1eoYR+p/IoC QP5Y0CsNAjrQqZwNKXG0gQxtzCbNCh5Qdd7whZSQ= Received: by simark.ca (Postfix) id 948D11E033; Mon, 13 Jul 2026 08:26:30 -0400 (EDT) Message-ID: Date: Mon, 13 Jul 2026 08:26:30 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] gdb: Fix assignment to TYPE_CODE_FLAGS registers To: srinath.parvathaneni@arm.com, gdb-patches@sourceware.org Cc: guinevere@redhat.com, thiago.bauermann@linaro.org, luis.machado.foss@gmail.com, Ezra.Sitorus@arm.com References: <20260713091126.2914903-1-srinath.parvathaneni@arm.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20260713091126.2914903-1-srinath.parvathaneni@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 7/13/26 5:11 AM, srinath.parvathaneni@arm.com wrote: > From: Srinath Parvathaneni > > GDB reports "Invalid cast" when assigning small integer literals (32-bit) to > 64-bit TYPE_CODE_FLAGS registers. For example, with the existing upstream FPMR > register, set $fpmr = 0x777777777 succeeds, whereas set $fpmr = 0x77 fails with > "Invalid cast" and this patch fixes the issue but makes changes to a generic > function value_cast in gdb/valops.c. > > * testsuite/gdb.arch/aarch64-fpmr.exp : Add "set $fpmr" test. > * gdb/valops.c (value_cast): Add TYPE_CODE_FLAGS condition to integer > assignment. > > Regression tested on aarch64-none-linux-gnu with no regressions. > > Ok for GDB master? This seems fine to me, but I am not as confident with this value_cast code as I am with other things, so I'll give you the: Approved-By: Simon Marchi but wait ~1 week before pushing in case someone sees something I don't. Simon