Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Mark Pascal as case-insensitive
Date: Fri, 14 Nov 2025 12:41:24 +0100	[thread overview]
Message-ID: <cf397a64-4bd5-499e-a0b4-85e78c538b3c@suse.de> (raw)
In-Reply-To: <20251113162811.616219-1-tromey@adacore.com>

On 11/13/25 5:28 PM, Tom Tromey wrote:
> The Pascal language is not case-sensitive, so implement the
> appropriate language method.  This fixes gdb.pascal failures with
> -gw3.
> 
> I wasn't sure if -gw3 should be the default so I've left it as-is.
> 

Hi,

I've tried out the patch with:
...
$ make check TESTS=gdb.pascal/*.exp 
RUNTESTFLAGS=--target_board=unix/gdb:debug_flags=-gw2
...
and likewise with -gw3, and the results look good.

LGTM.

Approved-By: Tom de Vries <tdevries@suse.de>

Thanks,
- Tom


> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33617
> ---
>   gdb/p-lang.h | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/gdb/p-lang.h b/gdb/p-lang.h
> index 87430bad13c..f3bb329bc02 100644
> --- a/gdb/p-lang.h
> +++ b/gdb/p-lang.h
> @@ -154,6 +154,9 @@ class pascal_language : public language_defn
>     bool range_checking_on_by_default () const override
>     { return true; }
>   
> +  enum case_sensitivity case_sensitivity () const override
> +  { return case_sensitive_off; }
> +
>   private:
>   
>     /* Print the character C on STREAM as part of the contents of a literal
> 
> base-commit: a85f1da7a82fef8c74737089b5845bfd2d97996c


  reply	other threads:[~2025-11-14 11:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13 16:28 Tom Tromey
2025-11-14 11:41 ` Tom de Vries [this message]
2025-11-14 12:59   ` Tom de Vries
2025-11-14 19:08     ` Tom Tromey
2025-11-14 22:02       ` Paul Koning
2025-11-15  2:30         ` Maciej W. Rozycki
2025-11-17 15:03           ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf397a64-4bd5-499e-a0b4-85e78c538b3c@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox