From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4R3TLZQVF2nyPQEAWB0awg (envelope-from ) for ; Fri, 14 Nov 2025 06:42:12 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=XlgiX8DV; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=EpnPWJn8; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ujPZwP9C; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=CoEtZ6cS; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id ACBC71E0B8; Fri, 14 Nov 2025 06:42:12 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CFD621E057 for ; Fri, 14 Nov 2025 06:42:11 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7ED943858405 for ; Fri, 14 Nov 2025 11:42:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7ED943858405 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=XlgiX8DV; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=EpnPWJn8; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ujPZwP9C; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=CoEtZ6cS Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 5763D3858D20 for ; Fri, 14 Nov 2025 11:41:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5763D3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5763D3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763120495; cv=none; b=oYS6d2c43mr85k2uWldmNijqNr6nNjo3cwPj/+9wsEV+R8mIEjxevhNeeo35/7WpupY9V9lSnOqogFgzUWT90tfOcotY9nLdFs4AN9iHj542wUb23O/Hk6zHi1K0xahsm7WomvrczkNUb06p/DQvl9w/dTSAOhtg9LsQV71/564= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763120495; c=relaxed/simple; bh=dPSEVIwcKw7SjtUmQCRz5sK+pf35uu2Yxy0I/k/Vz9I=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=RKbyVUAvQc56bj++Ew9mePSDQqYg92kvtn9XgtGpJHnnnpL9LiJQAwlUILLZBChVsT8rTJmj4QuUCGFbETOdn/thcK76MO5dofWOQjmO4FFyvOJUaW5K7dH/7xOoLdX+QSrfum/KKarMyOrimOaCXBJqlEfCyN5yrNj/drS3uYY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5763D3858D20 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 20CE91F79F; Fri, 14 Nov 2025 11:41:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1763120494; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9JgKMpe3WMJ3Q3fl8J0xVxzXf1SS61cHUFJyIX7HfOk=; b=XlgiX8DV2e17HTHFRRjv9+e8+7sqoLAtimRZfl7n8VR7YcW8Yl8Of6JeKJiXE0E9/r7DwJ /YxKh/D8SJDRdYXy64/tKWhz/I6FzGKlObDWflhFH6+yXUAzzKTmA2vQ1qztABxgvU49ml JR0DZfTyeqNoVTkmXrYqi8vhfgQSwAQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1763120494; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9JgKMpe3WMJ3Q3fl8J0xVxzXf1SS61cHUFJyIX7HfOk=; b=EpnPWJn8xsQcA04gDdP/XgY6CxHWErx6t4kVk3qeqwjngnrK4ibsakZGwg5jBgjWEleuEU kLRPd/FXX28lm4Cg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ujPZwP9C; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=CoEtZ6cS DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1763120493; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9JgKMpe3WMJ3Q3fl8J0xVxzXf1SS61cHUFJyIX7HfOk=; b=ujPZwP9C3XEpUFScHSjQSVQ1daYzMgYSxereLefI+8MWisFz8A/EDzrQ0ZYt7NVeV4ACJH w3x29CnFCnQqmod70wp0sR9MK5GXk3l0wTDkkEWqdUgDYrff4UEZBPpB4j1L5mDD462UXA y4Y9TZk8pdi4YGwvUDK6NWeCgI9xAbE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1763120493; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9JgKMpe3WMJ3Q3fl8J0xVxzXf1SS61cHUFJyIX7HfOk=; b=CoEtZ6cSpECfgtOgVVszXpjMbT3uYXcJSbd+4bMZuwoowIXGFLFY04w9LBOVXGEObieDv9 amG6yzNjLJl46+Dw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0747C3EA61; Fri, 14 Nov 2025 11:41:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id xHOLAG0VF2mgVAAAD6G6ig (envelope-from ); Fri, 14 Nov 2025 11:41:33 +0000 Message-ID: Date: Fri, 14 Nov 2025 12:41:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Mark Pascal as case-insensitive To: Tom Tromey , gdb-patches@sourceware.org References: <20251113162811.616219-1-tromey@adacore.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <20251113162811.616219-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 20CE91F79F X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:mid,suse.de:dkim]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 11/13/25 5:28 PM, Tom Tromey wrote: > The Pascal language is not case-sensitive, so implement the > appropriate language method. This fixes gdb.pascal failures with > -gw3. > > I wasn't sure if -gw3 should be the default so I've left it as-is. > Hi, I've tried out the patch with: ... $ make check TESTS=gdb.pascal/*.exp RUNTESTFLAGS=--target_board=unix/gdb:debug_flags=-gw2 ... and likewise with -gw3, and the results look good. LGTM. Approved-By: Tom de Vries Thanks, - Tom > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33617 > --- > gdb/p-lang.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gdb/p-lang.h b/gdb/p-lang.h > index 87430bad13c..f3bb329bc02 100644 > --- a/gdb/p-lang.h > +++ b/gdb/p-lang.h > @@ -154,6 +154,9 @@ class pascal_language : public language_defn > bool range_checking_on_by_default () const override > { return true; } > > + enum case_sensitivity case_sensitivity () const override > + { return case_sensitive_off; } > + > private: > > /* Print the character C on STREAM as part of the contents of a literal > > base-commit: a85f1da7a82fef8c74737089b5845bfd2d97996c