Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Luis Machado via Gdb-patches <gdb-patches@sourceware.org>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, nd <nd@arm.com>,
	"gdb-patches\\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/4] [ARM] Refactor pseudo register numbering
Date: Mon, 11 Oct 2021 10:06:21 -0300	[thread overview]
Message-ID: <ced24220-fd63-ff66-911a-8a7f5313dac7@linaro.org> (raw)
In-Reply-To: <AED85EB2-91EA-469B-B848-9DDD14C317FE@arm.com>

On 10/8/21 1:04 PM, Alan Hayward wrote:
> This is similar to AArch64 target, so mostly Lgtm...
> 
>> On 5 Oct 2021, at 15:45, Luis Machado <luis.machado@linaro.org> wrote:
>>
>> The pseudo register handling for ARM uses some hardcoded constants to
>> determine types and names.  In preparation to the upcoming MVE support
>> patch (that will add another pseudo register), this patch refactors and
>> reorganizes things in order to simplify handling of future pseudo registers.
>>
>> We keep track of the first pseudo register number in a group and the number of
>> pseudo registers in that group.
>>
>> Right now we only have the S and Q pseudo registers.
> 
> Renaming NEON to Q makes sense.
> 
> Why not rename VFP to S?

Yeah, might as well, since it makes more sense. I'll do it before pushing.

Thanks.

  reply	other threads:[~2021-10-11 13:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-05 14:45 [PATCH 0/4] [ARM] M-profile MVE extension support Luis Machado via Gdb-patches
2021-10-05 14:45 ` [PATCH 1/4] [ARM] Refactor some constants Luis Machado via Gdb-patches
2021-10-08 16:03   ` Alan Hayward via Gdb-patches
2021-10-05 14:45 ` [PATCH 2/4] [ARM] Small refactoring of arm gdbarch initialization Luis Machado via Gdb-patches
2021-10-08 16:03   ` Alan Hayward via Gdb-patches
2021-10-05 14:45 ` [PATCH 3/4] [ARM] Refactor pseudo register numbering Luis Machado via Gdb-patches
2021-10-08 16:04   ` Alan Hayward via Gdb-patches
2021-10-11 13:06     ` Luis Machado via Gdb-patches [this message]
2021-10-05 14:45 ` [PATCH 4/4] [ARM] Add support for M-profile MVE extension Luis Machado via Gdb-patches
2021-10-05 15:55   ` Eli Zaretskii via Gdb-patches
2021-10-08 16:34   ` Alan Hayward via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ced24220-fd63-ff66-911a-8a7f5313dac7@linaro.org \
    --to=gdb-patches@sourceware.org \
    --cc=Alan.Hayward@arm.com \
    --cc=luis.machado@linaro.org \
    --cc=nd@arm.com \
    --cc=peter.maydell@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox