From: Simon Marchi <simark@simark.ca>
To: John Baldwin <jhb@FreeBSD.org>, gdb-patches@sourceware.org
Subject: Re: [PING][PATCH v2 00/11] Support for thread-local variables on FreeBSD
Date: Tue, 12 Mar 2019 20:21:00 -0000 [thread overview]
Message-ID: <ceaca38f-957a-1646-84e9-481b1c1c8bc6@simark.ca> (raw)
In-Reply-To: <2b9d1e4b-507c-748d-060f-363ed9656406@FreeBSD.org>
On 2019-02-22 12:21 p.m., John Baldwin wrote:
> On 2/8/19 4:40 PM, John Baldwin wrote:
>> Relative to the first version the changes are:
>>
>> - Patch 2 fixes some #ifdef's pointed by Simon in amd64-bsd-nat.c.
>> - Patch 3's description has been reworked to narrow down the cases in
>> which it applies.
>> - Patch 5 is a new cleanup patch
>> - Patch 6 is a new patch that introduces a new method to lookup the
>> offset of a field in a structure. It is slightly more general than
>> just returning offsets so that it can hopefully be used to replace
>> the lk_find_field function in the Linux kernel patchset.
>> - Patch 7 (formerly 5) now uses the new method from Patch 6 to lookup
>> the offsets of two fields in a runtime linker structure instead of
>> parse_and_eval_long with manual offsetof.
>>
>> John Baldwin (11):
>> Support the fs_base and gs_base registers on i386.
>> Support fs_base and gs_base on FreeBSD/i386.
>> Handle an edge case for minisym TLS variable lookups.
>> Add a new gdbarch method to resolve the address of TLS variables.
>> Remove code disabled since at least 1999 from lookup_struct_elt_type.
>> Add a more general version of lookup_struct_elt_type.
>> Add a helper function to resolve TLS variable addresses for FreeBSD.
>> Support TLS variables on FreeBSD/amd64.
>> Support TLS variables on FreeBSD/i386.
>> Support TLS variables on FreeBSD/riscv.
>> Support TLS variables on FreeBSD/powerpc.
>
> I'll probably wait until the 8.3 branch if this is OK'd. Simon looked at
> the first 3 patches previously (though 3 has a new description since the
> first series). Andrew ok'd the FreeBSD/riscv patch as well. The
> FreeBSD-specific ones are probably ok, but patches 4-6 probably could use
> at least some looking over.
Hi John,
Since nobody else answered to patch 4, I am fine with you pushing the
series, we should have plenty of time before the next release to fix any
problem.
Thanks,
Simon
prev parent reply other threads:[~2019-03-12 20:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 0:42 [PATCH " John Baldwin
2019-02-09 0:42 ` [PATCH v2 11/11] Support TLS variables on FreeBSD/powerpc John Baldwin
2019-03-07 16:26 ` Simon Marchi
2019-02-09 0:42 ` [PATCH v2 09/11] Support TLS variables on FreeBSD/i386 John Baldwin
2019-02-09 0:42 ` [PATCH v2 03/11] Handle an edge case for minisym TLS variable lookups John Baldwin
2019-02-09 0:42 ` [PATCH v2 02/11] Support fs_base and gs_base on FreeBSD/i386 John Baldwin
2019-02-09 0:42 ` [PATCH v2 06/11] Add a more general version of lookup_struct_elt_type John Baldwin
2019-02-09 1:08 ` John Baldwin
2019-02-11 10:27 ` Philipp Rudo
2019-02-11 17:44 ` John Baldwin
2019-03-07 15:53 ` Simon Marchi
2019-03-08 0:04 ` John Baldwin
2019-03-08 0:32 ` Pedro Alves
2019-03-08 18:39 ` John Baldwin
2019-02-09 0:42 ` [PATCH v2 01/11] Support the fs_base and gs_base registers on i386 John Baldwin
2019-02-09 0:42 ` [PATCH v2 08/11] Support TLS variables on FreeBSD/amd64 John Baldwin
2019-02-09 0:42 ` [PATCH v2 07/11] Add a helper function to resolve TLS variable addresses for FreeBSD John Baldwin
2019-03-07 16:18 ` Simon Marchi
2019-02-09 0:50 ` [PATCH v2 04/11] Add a new gdbarch method to resolve the address of TLS variables John Baldwin
2019-03-07 16:08 ` Simon Marchi
2019-03-07 23:50 ` John Baldwin
2019-03-08 2:55 ` Simon Marchi
2019-03-08 18:39 ` John Baldwin
2019-02-09 0:50 ` [PATCH v2 10/11] Support TLS variables on FreeBSD/riscv John Baldwin
2019-02-09 0:50 ` [PATCH v2 05/11] Remove code disabled since at least 1999 from lookup_struct_elt_type John Baldwin
2019-03-07 16:25 ` Simon Marchi
2019-02-22 17:22 ` [PING][PATCH v2 00/11] Support for thread-local variables on FreeBSD John Baldwin
2019-03-12 20:21 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceaca38f-957a-1646-84e9-481b1c1c8bc6@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox