From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52240 invoked by alias); 12 Mar 2019 20:21:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52229 invoked by uid 89); 12 Mar 2019 20:21:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=Baldwin, baldwin, formerly X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Mar 2019 20:21:36 +0000 Received: from [172.16.0.89] (192-222-157-41.qc.cable.ebox.net [192.222.157.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C666B1E182; Tue, 12 Mar 2019 16:21:34 -0400 (EDT) Subject: Re: [PING][PATCH v2 00/11] Support for thread-local variables on FreeBSD To: John Baldwin , gdb-patches@sourceware.org References: <2b9d1e4b-507c-748d-060f-363ed9656406@FreeBSD.org> From: Simon Marchi Message-ID: Date: Tue, 12 Mar 2019 20:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <2b9d1e4b-507c-748d-060f-363ed9656406@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2019-03/txt/msg00257.txt.bz2 On 2019-02-22 12:21 p.m., John Baldwin wrote: > On 2/8/19 4:40 PM, John Baldwin wrote: >> Relative to the first version the changes are: >> >> - Patch 2 fixes some #ifdef's pointed by Simon in amd64-bsd-nat.c. >> - Patch 3's description has been reworked to narrow down the cases in >> which it applies. >> - Patch 5 is a new cleanup patch >> - Patch 6 is a new patch that introduces a new method to lookup the >> offset of a field in a structure. It is slightly more general than >> just returning offsets so that it can hopefully be used to replace >> the lk_find_field function in the Linux kernel patchset. >> - Patch 7 (formerly 5) now uses the new method from Patch 6 to lookup >> the offsets of two fields in a runtime linker structure instead of >> parse_and_eval_long with manual offsetof. >> >> John Baldwin (11): >> Support the fs_base and gs_base registers on i386. >> Support fs_base and gs_base on FreeBSD/i386. >> Handle an edge case for minisym TLS variable lookups. >> Add a new gdbarch method to resolve the address of TLS variables. >> Remove code disabled since at least 1999 from lookup_struct_elt_type. >> Add a more general version of lookup_struct_elt_type. >> Add a helper function to resolve TLS variable addresses for FreeBSD. >> Support TLS variables on FreeBSD/amd64. >> Support TLS variables on FreeBSD/i386. >> Support TLS variables on FreeBSD/riscv. >> Support TLS variables on FreeBSD/powerpc. > > I'll probably wait until the 8.3 branch if this is OK'd. Simon looked at > the first 3 patches previously (though 3 has a new description since the > first series). Andrew ok'd the FreeBSD/riscv patch as well. The > FreeBSD-specific ones are probably ok, but patches 4-6 probably could use > at least some looking over. Hi John, Since nobody else answered to patch 4, I am fine with you pushing the series, we should have plenty of time before the next release to fix any problem. Thanks, Simon