From: Simon Marchi <simark@simark.ca>
To: Tom de Vries <tdevries@suse.de>,
Christian Biesinger <cbiesinger@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH][gdb] Mention CU offset for <artifical> if verbose
Date: Sun, 09 Feb 2020 12:16:00 -0000 [thread overview]
Message-ID: <ce4480dc-4470-4b04-5bb8-ef8835930ea3@simark.ca> (raw)
In-Reply-To: <99e7c8e5-8662-5b66-9d05-6ec3581b08bd@suse.de>
On 2020-02-09 6:48 a.m., Tom de Vries wrote:
> I've done that now by using gdb::unique_xmalloc_ptr<char>. [ FWIW,
> there's some code in create_type_unit_group that does something similar,
> but there we use std::string and string_printf. ]
You could use std::string and string_printf here as well, but what you did
is fine. The patch LGTM.
Thanks!
>
> Also, I realized that the code was too deep in the call stack, and I've
> brought it one level up, to process_psymtab_comp_unit_reader, to make
> sure it doesn't trigger for f.i. create_type_unit_group.
>
> Thanks,
> - Tom
next prev parent reply other threads:[~2020-02-09 12:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 11:34 Tom de Vries
2020-02-07 14:45 ` Christian Biesinger via gdb-patches
2020-02-08 9:16 ` Tom de Vries
2020-02-08 15:48 ` Simon Marchi
2020-02-09 11:48 ` Tom de Vries
2020-02-09 12:16 ` Simon Marchi [this message]
2020-02-09 13:35 ` Tom Tromey
2020-02-10 10:18 ` [PATCH][gdb] Fix -Wstrict-null-sentinel warnings Tom de Vries
2020-02-10 14:08 ` Simon Marchi
2020-02-10 14:19 ` Tom de Vries
2020-02-11 15:14 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce4480dc-4470-4b04-5bb8-ef8835930ea3@simark.ca \
--to=simark@simark.ca \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox