From: Tom de Vries <tdevries@suse.de>
To: Simon Marchi <simark@simark.ca>, Tom Tromey <tom@tromey.com>
Cc: Christian Biesinger <cbiesinger@google.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH][gdb] Fix -Wstrict-null-sentinel warnings
Date: Mon, 10 Feb 2020 14:19:00 -0000 [thread overview]
Message-ID: <21aebb7c-51bf-8ce9-f383-1c1421327578@suse.de> (raw)
In-Reply-To: <0e65dcad-227e-1612-7d7d-f6de9db40493@simark.ca>
On 10-02-2020 15:08, Simon Marchi wrote:
> On 2020-02-10 5:18 a.m., Tom de Vries wrote:
>> [ was: Re: [PATCH][gdb] Mention CU offset for <artifical> if verbose ]
>>
>> On 09-02-2020 14:35, Tom Tromey wrote:
>>>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>>>
>>> Tom> + debug_filename.reset (concat (artificial, "@",
>>> Tom> + sect_offset_str (per_cu->sect_off), NULL));
>>>
>>> When passing NULL to concat, you either need nullptr or (char *) NULL.
>>
>> Fixed in attached patch.
>>
>> OK for trunk?
>
> I think we usually put a space after the cast:
>
> (char *) NULL
>
Ack, committed with that fixed.
Thanks,
- Tom
> Also, if we want to enforce this warning, it should be added to gdb/warning.m4. Makefiles
> in gdb/ and gdbserver/ should be re-generated. gdbsupport/ doesn't use AM_GDB_WARNINGS at
> the moment.
next prev parent reply other threads:[~2020-02-10 14:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 11:34 [PATCH][gdb] Mention CU offset for <artifical> if verbose Tom de Vries
2020-02-07 14:45 ` Christian Biesinger via gdb-patches
2020-02-08 9:16 ` Tom de Vries
2020-02-08 15:48 ` Simon Marchi
2020-02-09 11:48 ` Tom de Vries
2020-02-09 12:16 ` Simon Marchi
2020-02-09 13:35 ` Tom Tromey
2020-02-10 10:18 ` [PATCH][gdb] Fix -Wstrict-null-sentinel warnings Tom de Vries
2020-02-10 14:08 ` Simon Marchi
2020-02-10 14:19 ` Tom de Vries [this message]
2020-02-11 15:14 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21aebb7c-51bf-8ce9-f383-1c1421327578@suse.de \
--to=tdevries@suse.de \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox