Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Lancelot SIX <Lancelot.Six@amd.com>
To: Pedro Alves <pedro@palves.net>,
	gdb-patches@sourceware.org, John Baldwin <jhb@FreeBSD.org>
Subject: Re: [PATCH v4] Teach GDB to generate sparse core files (PR corefiles/31494)
Date: Fri, 22 Mar 2024 10:26:17 +0000	[thread overview]
Message-ID: <cd296cc4-76ad-46bf-976d-590d619e80c5@amd.com> (raw)
In-Reply-To: <f4215076-fbd8-4946-939e-1cb898f01136@palves.net>

> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31494
> Reviewed-By: Lancelot Six <lancelot.six@amd.com>
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
> Reviewed-By: John Baldwin <jhb@FreeBSD.org>
> Change-Id: I2554a6a4a72d8c199ce31f176e0ead0c0c76cff1
> ---
>   gdb/NEWS                           |   4 +
>   gdb/doc/gdb.texinfo                |   3 +
>   gdb/gcore.c                        | 186 +++++++++++++++++++++-
>   gdb/testsuite/gdb.base/bigcore.exp | 238 ++++++++++++++++-------------
>   4 files changed, 323 insertions(+), 108 deletions(-)
> 


I just had a quick look at the changes, and that looks good to me.

Thanks for doing this!

Lancelot.

  reply	other threads:[~2024-03-22 10:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-15 18:27 [PATCH] " Pedro Alves
2024-03-15 18:40 ` Eli Zaretskii
2024-03-18 13:29 ` [PATCH v2] " Pedro Alves
2024-03-18 17:43   ` [PATCH v3] " Pedro Alves
2024-03-19 16:41     ` John Baldwin
2024-03-21 21:27     ` Lancelot SIX
2024-03-21 23:14       ` [PATCH v4] " Pedro Alves
2024-03-22 10:26         ` Lancelot SIX [this message]
2024-03-22 12:33           ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd296cc4-76ad-46bf-976d-590d619e80c5@amd.com \
    --to=lancelot.six@amd.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jhb@FreeBSD.org \
    --cc=pedro@palves.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox