From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id vroRB/Rc/WU2ZREAWB0awg (envelope-from ) for ; Fri, 22 Mar 2024 06:27:00 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=2ywE+99P; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 07B661E0C0; Fri, 22 Mar 2024 06:27:00 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BCB4F1E030 for ; Fri, 22 Mar 2024 06:26:57 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C55CC3858415 for ; Fri, 22 Mar 2024 10:26:56 +0000 (GMT) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2047.outbound.protection.outlook.com [40.107.244.47]) by sourceware.org (Postfix) with ESMTPS id 9EDE63858D20 for ; Fri, 22 Mar 2024 10:26:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9EDE63858D20 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9EDE63858D20 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.244.47 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1711103196; cv=pass; b=gFsLJ1IzEY2PWYvI8QYmfSANbe1JelE7sqToxu/oFnp8dsm0hkQeAqYvfaN5aZRgTuOtsloX6XP3WRfCeS4pw8JCpTan5R9GgyqtWNnewDzsDIuVDxur4vwH0vn3rmbbZiqSnvPnqcCOoeoMQJKZ+f6kfDb8x/m/SJd0LJzYGg4= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1711103196; c=relaxed/simple; bh=jZpmyW/7RtfAk9bOmfG5D0IFZblLxORvyou7PVYNnG0=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=rCq8BLPMsT1uPOgO+Z+Oxid5qGh9bHJcOUse0+x2Fudw09jSZR++HZtszgmRqQJFNApmdS5zwliRD24Pjk/akh1xXmhqyKEXvFuhnKtJQp1G75fXM0MV3pO620a7tIiFFrYZkxPzUBeksL9dX8C0hDDdE72fyI3hNZFjkurGSqQ= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QEXaTZw88NBhJURoUuTj0bhZ1ArSDk+tIGKhOm/DlR6Uaj2zKkrpIh7eM/2o2/MTPRd3qgHz2YXnmYiq7M8THvXk5+V209GYgodNxyoWPMGzTx5tPAhGotNZOHWXoeQNm3xXe2mjNl/eTCLgUnrtdJqDYBqVHKrFUI3dTGCj5ouv7eif6ImIXScdjsSn5hPTbXJtHS4u034yYLh2sUfzVYRUgkWm34Q2UO7onNJGpl3bYoB0uwCqnHmIxU9f80rzZQXinOB2mMXQAvolsuV5DNw2B9lSsO5Kqn2VRqDeu6tfgmufFuqkgSQgSHM3TJGFUZ69OHN0uMOLBeMSAnUqLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zpho3pheTREUMXOpi8eInLqE5k5nxOuLlkEkGiuOd3Q=; b=M6Wm8I46mrV7Zqg9DW9U3JSA+SVaYm4oJ2lvc1THX1XLeBAMweo6cp5GRicVehKbAk0hewuv9+sHLiTD3EdUPM6eh5R0V2M5RUv54pDY7tzxhrRjEmmKrJaZn+gLvshIWkl9mKNNbv9BQ74xyz5u1gkEly3k/1R1o0O7sfa2qRcool+v8PkAHEYiJrpB/Cp2qMGJZd9WeiQ1+/tMLeHGulOVboZvDzXZeiYzstcSzIwGLDqr7e3E6B7qdsuE4TDgn8fxnwdJOFs1n7tSmmJ2h6lOkQ7IAGqAblLe+IWv1/p2mKyklEaUyOQhEKX2CNgEa1hvybqrLjxrduh8q1TcOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zpho3pheTREUMXOpi8eInLqE5k5nxOuLlkEkGiuOd3Q=; b=2ywE+99PReuKGLDEiqmOq7f7OsTYMnFGkGjx4NQjWlegE0MN1TH4M3yvyHhW4pFfhn/gcj8iLNAxeV8VNrQVAL1kTlm0wg/9/dEOpLlGEcowJ0R3gR99kyd7S29E44VhDdmMUfupulHqY1UZltDcnO5KMMPrHqDAcVsXrf41U6k= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) by PH8PR12MB6818.namprd12.prod.outlook.com (2603:10b6:510:1c9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.30; Fri, 22 Mar 2024 10:26:22 +0000 Received: from CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::f98e:8d91:f485:89f9]) by CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::f98e:8d91:f485:89f9%3]) with mapi id 15.20.7409.022; Fri, 22 Mar 2024 10:26:22 +0000 Message-ID: Date: Fri, 22 Mar 2024 10:26:17 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] Teach GDB to generate sparse core files (PR corefiles/31494) To: Pedro Alves , gdb-patches@sourceware.org, John Baldwin References: <20240315182705.4064062-1-pedro@palves.net> <1cb2e4f4-f14d-4434-9eb2-b33fdf4bf0bb@palves.net> <269ff31a-9aeb-4293-a4d9-df0f16f12e88@palves.net> <5f504bb2-75b2-43fb-b74f-708cf0c46bb6@amd.com> Content-Language: en-US From: Lancelot SIX In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: VI1PR10CA0111.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:803:28::40) To CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB9079:EE_|PH8PR12MB6818:EE_ X-MS-Office365-Filtering-Correlation-Id: 0293760c-1ff7-4872-447a-08dc4a5a84fe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zPuymv0tru9fLiiPrbWoZlr3FjWGmy2ve4fUFHWoxr10HJKbCTRkWg74T7In6MU9xLd8v+XNBrpnTFrHam+xYnkhpwJ86CcHBi/rdfQkjR8zI2qKPKLX8vKppA1j+xVkDKgjbFRdBsqAgFOUgawH+/C3UsYEArkP1F9UoermpAGiVbDlLOJQvhIVQGla7sgsJwMW9UXODeFTF70m9es0mFrYz6yqNbk6TEIwjhijs2LlCJv9EpKqdPavPSCuJTagW9O98AxhBVyB6yLH64foJ+Ne+4XXz4/83nWYMo3iMyNr/M6Gi2Ci2JEOsOQyZUYZlju+JKEYxyKtbTqOEQuxO0wN1EBM2OyJhaQpiKzAOJAWUfgVnP9BnIb6l9qEfW3q+Y4g6S1iKR8BeaP6NUkJ5sH4SEyugM9lOF3tuzHZYSltkMWKCiAym2rIeiaVL3CPL4IbP6W8ReZY0ZWDQmb/D4Dg1mXaPT9znJ9r6XdU8NnaCsZdTvCUKhl/OVon/yzrfrG1nhpGf9UMXgcQgBGoeyFUCeACvRKyZedIn7UZm//PFsNv5F2yvZtDRVG0Y2J6HJa7ZFkygomydNSPFwp4hPAtItcyDHth5SDf1pJjLkQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB9079.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVRMYzdQWjBWV2ptVkI4bzBIMnZKa05zWnhESWNpSk1vTUdyS3k1RXRzbEdB?= =?utf-8?B?TGx4VU04cmEwK0J6ZnlTZzl6V3VUbWc1djd3dW5VcHFTeGNjbmYyU1J3eWsv?= =?utf-8?B?MzMwRnFHd2ZTSGsvNEdLTUZEYVhKajVvaTB0dXByaEZXRFg0bTFMOUF1Mkt4?= =?utf-8?B?bFM4K2N2MmRabTdzYzcyUUI3bVZVV1RtRktQbjl6NExmeE50MG5YZXBpWjVT?= =?utf-8?B?Zk5NU2RWT3ovVnp1TmFFRFl3b3lFcnBXMVZBZk5qV3UzRWRhWngwL3B6NXI5?= =?utf-8?B?Tm9lRDd4YkxGcTNYOU9NWjdyN2IvVDFYOFRlbVJzR2ZMalJ5K0tOU05XazNN?= =?utf-8?B?THo3Tm1WbmxJQktpbGFYR2pBZjY0aUVZVDZDREtJQlVGaU9vVURJM2wrL3dM?= =?utf-8?B?RkgwZCt2Mi9UUU80S1Y4bWlHbURuQkkyOWt4RUxQU1lyaDlyVWJtN1hOME5I?= =?utf-8?B?ZTFHUHZNNnhEY3NteVg5UWtwTEw3T2tQTUhNV3I4WDVQRlhhaWJCeURVOHNi?= =?utf-8?B?ckR0SGJDSEJYbmxFUTBDZTZpbFlmYmpmK2dtREhwd0daVWFINFM3cGNsV0Zj?= =?utf-8?B?bkhXb2s5Z3lMNml0MEU1ejQxVUZRZ1ZjWVVFN0NnQmdPTUtKeEZaNVlnRnpR?= =?utf-8?B?OGVjeDAvdWJ6bFZlK21OUzhIRCtQd3RMNVhxYnpJQ0NTdU84MHh6cHI5VkVi?= =?utf-8?B?MnVoclEzam9qVUUvOCtkSVZhRWdEWU4xNG5JZXNhUWp0ODdmZ1hNUkN1SDJ5?= =?utf-8?B?NlBUb1g2QzRUYURZY2tWRzcvbTVEWkhWVGZ1SlEvS001RGFqRlV6Slc3YW9P?= =?utf-8?B?cW1odlRZNTdueVUxNElNL21zNnZLOWFiRlJwNGRURDJPMGRVbW9WZDFvaXJa?= =?utf-8?B?ZFMwdG9qTWRyUTBFbk5Sek41Q1BBdFovU3NwZ2lmaTJVNVEvRzFPTW1Zc3gr?= =?utf-8?B?NHpCWGFZdnNmVjBYalE4Qk1OSmVuMUVpcGs2Z3lpaUpneTRKcUNZMDNGR1VK?= =?utf-8?B?bDN2c250dnBTY1JSRkRYbDVUL3NVSTFHa1FwbUdzbTJUbEV3b3k2WEtidWND?= =?utf-8?B?QlgvaVpCU0RaSXZYd2hCbTJEaEZHbXlPV0tmSXZFQ0IzblM2WmFmamp6Nzk5?= =?utf-8?B?YkV6TE5tUVZnMVl2RGZPcFZadlNrdWVjbkdXWGpab2FkYmZLWTZqbkxMK3dO?= =?utf-8?B?bDhGZWRkVkF4UDhlZ0dtd1pWVVozZUJlWGhxNUF4ckJvdFZaTG9wSk9selYx?= =?utf-8?B?OUE1dmxzOGZvWm54RmdKSkZPWVVXRjNFT3pQNC9vSWVKV3N3ZjdMcHJIVUVu?= =?utf-8?B?MXo1dm8wZldUaTZ0WDNPVW8wU1Z3VnVYdHhPRWEyakpqVjRCeWQvRTFnU245?= =?utf-8?B?SEV0dk5TanRQd3d3SjBQRzdGVDNkSThmQkhybkJVWVNzQWZMYjFIZVBXUDdU?= =?utf-8?B?cGkreGMxaDE3VmVyb3R2Mm5PdlhjSUxUemN3ZUV5aTJLNndRUWRhL1pRb0pR?= =?utf-8?B?bDNIM2VOV0tBNzdNa0hYK0VJNm1PMXJFK3pJZVM4bDNkZmhyUlBlNWNvRW51?= =?utf-8?B?UDkreEJrT3hRM2tPb2NQYWU3NEtGUmtwblU1dkNFMEttS3lnMFlOZXMvS0o3?= =?utf-8?B?V2lRaUNWUXF0dVJHMkpkZEJuQ3kxcFJIaHcxVG1maDVxSHBBNlJycFRmL0Fy?= =?utf-8?B?SVhtMzN2dGVJaExCOWxXa1h4bEQyZWZva09Vc2VFbWo2K3NxTktqaGhOVk80?= =?utf-8?B?b2w4a25TM091M1BjbDc0L3pSaHd2VEFCM0NQUzZLdWQxbjV3UGhKbi9SOHY2?= =?utf-8?B?NHA1NG9kcnBzOXZDa09LcUR6bm43ZFluT2xFU204Vncwc0hRN2VQc3F0Y2w1?= =?utf-8?B?bG9JWjhiMytvRElDQnFZbXN1a3ltQ2pHVnNSTEJ5S1RJWHluU002Q0NFQmdn?= =?utf-8?B?cmRRZk9EanplRjRTbEUxUjlONGtIL0ZXWWtrOXV6NUJ4K2RXTkh2T2hEMWIy?= =?utf-8?B?Ly9XV3E2Vit1OEtNdHVlNGJLRnNycXhtUjI3ZXgrNEtpUXQvOGZrVDJtcnh1?= =?utf-8?B?SFdKKzFqeFRDY3hUVnV3NTI5VlBoemtrQ3JkUHlkSWRENFJ0aENyL1ZhTnhp?= =?utf-8?Q?DrUfWN5owpuZh8kG7kRShml4T?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0293760c-1ff7-4872-447a-08dc4a5a84fe X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2024 10:26:22.0923 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eCO5kqJy84ptLR2emzvtvUzywGdeb3UrC6OIv4BP2LvJWnGRQsPHO4Ja6dG0lFgSs1fIYkGyA6ujbBYcyA27jQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6818 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31494 > Reviewed-By: Lancelot Six > Reviewed-By: Eli Zaretskii > Reviewed-By: John Baldwin > Change-Id: I2554a6a4a72d8c199ce31f176e0ead0c0c76cff1 > --- > gdb/NEWS | 4 + > gdb/doc/gdb.texinfo | 3 + > gdb/gcore.c | 186 +++++++++++++++++++++- > gdb/testsuite/gdb.base/bigcore.exp | 238 ++++++++++++++++------------- > 4 files changed, 323 insertions(+), 108 deletions(-) > I just had a quick look at the changes, and that looks good to me. Thanks for doing this! Lancelot.