From: Keith Seitz <keiths@redhat.com>
To: Dragorn421 <dragorn421@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PING][PATCH v4 0/2] Fix `add-symbol-file -o ... -s ...` address mapping bug
Date: Wed, 14 Oct 2026 09:44:18 -0700 [thread overview]
Message-ID: <cc640eed-6afc-4c5d-a570-ad8be32f53fb@redhat.com> (raw)
In-Reply-To: <CA+_Su2L2UQ8UQq9KjcqQvwoHa_ovpQgt=5bn0uN_u3Nt-_yDGw@mail.gmail.com>
On 10/12/26 12:27 AM, Dragorn421 wrote:
> Kindly pinging.
>
I apologize for the delay...
> Le sam. 26 sept. 2026 à 08:48, Dragorn421 <dragorn421@gmail.com> a écrit :
>>
>> Hi!
>>
>> This fixes a bug when mixing -o and -s in the add-symbol-file command,
>> and adds a corresponding test.
>>
>> Initial patch thread here: https://sourceware.org/pipermail/gdb-patches/2026-September/230131.html
>> v3 here: https://sourceware.org/pipermail/gdb-patches/2026-September/230581.html https://sourceware.org/pipermail/gdb-patches/2026-September/230580.html
>>
>> v3 over v2 fixes the added test case.
>> v4 over v3 fixes formatting and addresses a review of the test case.
You've addressed all my concerns/issues, so this looks ready.
[You'll still have to wait for a global maintainer to approve,
though.]
Reviewed-By: Keith Seitz <keiths@redhat.com>
Keith
prev parent reply other threads:[~2026-10-14 16:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-26 6:47 [PATCH " Dragorn421
2026-09-26 6:47 ` [PATCH v4 1/2] " Dragorn421
2026-09-26 6:47 ` [PATCH v4 2/2] `add-symbol-file`: add test for mixing -o and -s Dragorn421
2026-10-12 7:27 ` [PING][PATCH v4 0/2] Fix `add-symbol-file -o ... -s ...` address mapping bug Dragorn421
2026-10-14 16:44 ` Keith Seitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc640eed-6afc-4c5d-a570-ad8be32f53fb@redhat.com \
--to=keiths@redhat.com \
--cc=dragorn421@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox