From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EBFrEYaxz2pL6wkAWB0awg (envelope-from ) for ; Wed, 14 Oct 2026 12:44:54 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=R6ZBU+CS; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2A43C1E04E; Wed, 14 Oct 2026 12:44:54 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2196D1E04E for ; Wed, 14 Oct 2026 12:44:53 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1F9D14BA23D1 for ; Wed, 14 Oct 2026 16:44:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1F9D14BA23D1 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=R6ZBU+CS Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 5F5B24BA2E04 for ; Wed, 14 Oct 2026 16:44:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5F5B24BA2E04 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5F5B24BA2E04 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791996265; cv=none; b=FIN9CQxBfJZ+HNsUCIH/mkc9NFASAQBBmyUDgtFy+djGVOWTXFtzK4VvRRRdrtHNac1qnhF7A7tL12x2X5rE4yauAFxegaN7RTqo4B+7E0mpg78xdKR+6xTq3GLd03mJ9d+FdAof9y3cKXIeQtDjrj7is2ys8L+rL525k3pUmIA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791996265; c=relaxed/simple; bh=meaR8dAUCLyKSReKsKbrpljFF11I1xh9vamSPEXP2bU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=f77yoF0775ePjyVhz/BXtiKORdVeFoHvVgJDCiG3ubD/a544l97Me2KBLwDyctd3kDzaPtQSzGO7Qp6bZIMV0a66sIx+fwt3JLE5Y6mo/DSB5AE8zvohkOR5SKRIVTC2PzDEuOd3hDYNuBOcVCrPe4hJ84VzqrBfeyDqPjVlTC4= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=R6ZBU+CS DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5F5B24BA2E04 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791996265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=toHpgnNdZeA5850DhwEvyjM47PTF/RHy4/lIfPqbNBg=; b=R6ZBU+CSOfx/UqbUTIzSMTN4OfMVXODly+2znvJW0WQ5t/ovQpLKpb4HuFNH4s+iIWqOfi MFGW0EeMXaP73j1fOgbHRryqOe0wvL+BMQOzoMZr0u7XQ4fM0/CUNrIvMfHID+luf6hcIb 7ncewNom2uEudeWzYhOUjK9BsOtQGxI= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-581-bz9ZZkoHO6afwxsT4nJBag-1; Wed, 14 Oct 2026 16:44:22 +0000 X-MC-Unique: bz9ZZkoHO6afwxsT4nJBag-1 X-Mimecast-MFC-AGG-ID: bz9ZZkoHO6afwxsT4nJBag_1791996261 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3a46f0f158dso4667621a91.1 for ; Wed, 14 Oct 2026 09:44:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791996261; x=1792601061; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=toHpgnNdZeA5850DhwEvyjM47PTF/RHy4/lIfPqbNBg=; b=WK3phBL1723UHugBSeqfUIv5qNW3KkGJggdyemT/0kP0oZ4/aFyzO3U11JUuhh9shb z+nkTAru8taGupAr6ggQREq2bxXo0rfWW0zFU2HUAc5l1c1JCgJGcqx7UqD5F1EdFkQr T6u/Xx6wpJc8WcTHSlA13TLXgOYHTI5mrkW8Zgml6Og7Ao6H4vlR6ISjIX6/NIeFXg16 MtPLn9XrAMOfiFDnKt4S1jFT4AG1alevBGKS/EEGlI0zsRyBSTJLhFAGGsuBJyk9SE6f OFEnPE8Uhuojq5hzK2Xt3zYSzNXAMnbbPL9ivxT3DJF/wTAdtFcDnle8J1/Vil8z4YEg 7Dow== X-Forwarded-Encrypted: i=1; AKwUvByiMPjpnjERQ9581ZBHurLSckuvTkRhg/Rmld4OQb3VavYWLk6eaxWCdXwIkGlH6mluh6uome2vq/gtMQ==@sourceware.org X-Gm-Message-State: AFq9FYJv6/0jkh+JtryJg9TyvzBcCBimePyfu/9YeYjFoMbPBdclbnTw jC4nWgVS2WAJZydxYo65tgRsTNn4MOjYE5rkSUznbu69lfnjdAr1WtHIHFXD9XO1pR9oFzki+iS gPTbzWYrUL6oMPzk/VAocTeES1+qy3ghIHbTNAHZVTV8U/aaCo/cM/jC/PN7FJs4= X-Gm-Gg: AYBFou2uMEzm/BKveX8fn1BuZwlONIBJih+Nw2Q6xhZgwcHxDYXcH/2+g6LIxRDj2g0 jTDwHmzOzGrBi09urs0/PuRVZklr33HMFeKcBXnN5e2oH3kBw3eq3eEX36FgYgz3fx62TtDSHYI 2z6qZ+R4Uc8t9TpWXFOcr0Z4UlDW6TEgYV3FowLyifSD6GBl+L7JgQJj8I4lNCe/zII0haa8+oI 1FfVW4Wi9Zwa2QcQKcLkXlSAJN6I2TZpIoxTj+K1CXCUTbV6gTcVVUx2yUfQNvsY0dwQFuy5PY1 Wl4gGGLMgL3qNMCrJRaPWi2V9Dy+wZvyfoVpWGnf8BnlkJqrBkTpjbsXAGIowXFrIJuNdyECLzP YKlEVqQ== X-Received: by 2002:a17:90b:4e8b:b0:3ab:be66:ddd3 with SMTP id 98e67ed59e1d1-3abbe66dfa9mr6903332a91.32.1791996261248; Wed, 14 Oct 2026 09:44:21 -0700 (PDT) X-Received: by 2002:a17:90b:4e8b:b0:3ab:be66:ddd3 with SMTP id 98e67ed59e1d1-3abbe66dfa9mr6903324a91.32.1791996260768; Wed, 14 Oct 2026 09:44:20 -0700 (PDT) Received: from [150.1.200.157] ([172.56.105.42]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ac9437aa5fsm235404a91.3.2026.10.14.09.44.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Oct 2026 09:44:20 -0700 (PDT) Message-ID: Date: Wed, 14 Oct 2026 09:44:18 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PING][PATCH v4 0/2] Fix `add-symbol-file -o ... -s ...` address mapping bug To: Dragorn421 , gdb-patches@sourceware.org References: <20260926064742.29327-1-dragorn421@gmail.com> From: Keith Seitz In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 4ZzkyH3_OvbIyzv9-1ubrhgrV-xtvHAJ89mfocwBA6I_1791996261 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/12/26 12:27 AM, Dragorn421 wrote: > Kindly pinging. > I apologize for the delay... > Le sam. 26 sept. 2026 à 08:48, Dragorn421 a écrit : >> >> Hi! >> >> This fixes a bug when mixing -o and -s in the add-symbol-file command, >> and adds a corresponding test. >> >> Initial patch thread here: https://sourceware.org/pipermail/gdb-patches/2026-September/230131.html >> v3 here: https://sourceware.org/pipermail/gdb-patches/2026-September/230581.html https://sourceware.org/pipermail/gdb-patches/2026-September/230580.html >> >> v3 over v2 fixes the added test case. >> v4 over v3 fixes formatting and addresses a review of the test case. You've addressed all my concerns/issues, so this looks ready. [You'll still have to wait for a global maintainer to approve, though.] Reviewed-By: Keith Seitz Keith