From: Pedro Alves <pedro@palves.net>
To: Hannes Domani <ssbssa@yahoo.de>,
Hannes Domani via Gdb-patches <gdb-patches@sourceware.org>,
Tom Tromey <tom@tromey.com>
Subject: Re: [PATCHv3 1/2] Initial TUI mouse support
Date: Fri, 4 Jun 2021 16:20:42 +0100 [thread overview]
Message-ID: <cc4f5727-253f-d1d1-def3-63eb93df1b8e@palves.net> (raw)
In-Reply-To: <1760297979.5212997.1622816480782@mail.yahoo.com>
On 2021-06-04 3:21 p.m., Hannes Domani via Gdb-patches wrote:
> Am Freitag, 4. Juni 2021, 15:51:27 MESZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben:
>
>>>>>>> "Hannes" == Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> writes:
>>
>> Hannes> Implements an overridable tui_win_info::click method whose arguments
>> Hannes> are the mouse coordinates inside the specific window, and the mouse
>> Hannes> button clicked.
>>
>> Hannes> And if the curses implementation supports 5 buttons, the 4th and 5th
>> Hannes> buttons are used for scrolling.
>>
>> Hannes> 2021-06-03 Hannes Domani <ssbssa@yahoo.de>
>>
>> Hannes> * ser-mingw.c (console_select_thread): Handle MOUSE_EVENT.
>> Hannes> * tui/tui-data.h (struct tui_win_info): Add click function.
>> Hannes> * tui/tui-io.c (tui_prep_terminal): Enable mouse events.
>> Hannes> (tui_deprep_terminal): Disable mouse events.
>> Hannes> (tui_dispatch_ctrl_char): Handle KEY_MOUSE.
>> Hannes> * tui/tui.c (tui_disable): Disable mouse events.
>>
>> Looks good. Thank you again.
>
> Pushed both, thanks.
>
Yay, mouse support finally. Thank you!
Don't we need a NEWS entry, though?
Pedro Alves
next prev parent reply other threads:[~2021-06-04 15:21 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210603151453.15248-1-ssbssa.ref@yahoo.de>
2021-06-03 15:14 ` Hannes Domani via Gdb-patches
2021-06-03 15:14 ` [PATCHv3 2/2] Forward mouse click to python TUI window Hannes Domani via Gdb-patches
2021-06-03 17:16 ` Eli Zaretskii via Gdb-patches
2021-06-04 13:52 ` Tom Tromey
2021-06-04 13:51 ` [PATCHv3 1/2] Initial TUI mouse support Tom Tromey
2021-06-04 14:21 ` Hannes Domani via Gdb-patches
2021-06-04 15:20 ` Pedro Alves [this message]
2021-06-04 16:06 ` Hannes Domani via Gdb-patches
2021-06-04 16:23 ` Pedro Alves
2021-06-04 18:59 ` Eli Zaretskii via Gdb-patches
2021-06-04 18:57 ` Eli Zaretskii via Gdb-patches
2021-06-04 16:29 ` Pedro Alves
2021-06-04 16:48 ` Hannes Domani via Gdb-patches
2021-06-04 18:05 ` Joel Brobecker
2021-06-04 18:13 ` Simon Marchi via Gdb-patches
2021-06-04 18:39 ` Joel Brobecker
2021-06-04 20:31 ` Pedro Alves
2021-06-04 20:43 ` Pedro Alves
2021-06-04 21:15 ` Hannes Domani via Gdb-patches
2021-06-04 22:19 ` Pedro Alves
2021-06-10 18:44 ` Tom Tromey
2021-06-13 17:26 ` Pedro Alves
2021-06-18 15:01 ` Tom Tromey
2021-06-18 17:42 ` Pedro Alves
2021-06-04 18:46 ` Tom Tromey
2021-06-04 20:54 ` Pedro Alves
2021-06-04 23:48 ` Pedro Alves
2021-06-05 14:40 ` Hannes Domani via Gdb-patches
2021-06-06 5:46 ` Eli Zaretskii via Gdb-patches
2021-06-10 18:46 ` Tom Tromey
2021-06-11 11:02 ` Hannes Domani via Gdb-patches
2021-06-12 2:41 ` POC: Make the TUI command window support the mouse (Re: [PATCHv3 1/2] Initial TUI mouse support) Pedro Alves
2021-06-12 12:32 ` Hannes Domani via Gdb-patches
2021-06-12 18:08 ` Pedro Alves
2021-06-13 2:46 ` [PATCH v2] Make the TUI command window support the mouse Pedro Alves
2021-06-13 10:35 ` Eli Zaretskii via Gdb-patches
2021-06-13 17:29 ` Pedro Alves
2021-06-13 18:02 ` Eli Zaretskii via Gdb-patches
2021-06-13 18:13 ` Pedro Alves
2021-06-13 13:04 ` Hannes Domani via Gdb-patches
2021-06-13 17:25 ` [PATCH v3] " Pedro Alves
2021-06-13 17:55 ` Hannes Domani via Gdb-patches
2021-06-13 17:59 ` Pedro Alves
2021-06-17 11:04 ` [PUSHED v4] " Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc4f5727-253f-d1d1-def3-63eb93df1b8e@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=ssbssa@yahoo.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox