From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id jNf/IeNEumDORQAAWB0awg (envelope-from ) for ; Fri, 04 Jun 2021 11:21:07 -0400 Received: by simark.ca (Postfix, from userid 112) id 7C9B31F163; Fri, 4 Jun 2021 11:21:07 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F1E881E54D for ; Fri, 4 Jun 2021 11:21:05 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8FB32399C02C for ; Fri, 4 Jun 2021 15:21:05 +0000 (GMT) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by sourceware.org (Postfix) with ESMTPS id 039513848415 for ; Fri, 4 Jun 2021 15:20:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 039513848415 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f48.google.com with SMTP id u7so4254414wrs.10 for ; Fri, 04 Jun 2021 08:20:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2zoqMizEtX77fDKowZ4NgrzKmuEpwrmJXdlRTM5mlY4=; b=bZ1ARtEBbJEGBQgq1Bc3BZR/xLf1EsPvFC3QHSCxDxT2epAw0MwdJghXxhAIU36142 5sbz4ecwxJWIPW4dtxhbVtYLyjJvT36olGK4naw/iyAvC52roADnfQNGWk9zIVAMz0vp PBJgMjS4reSqfAuUFkMDiObHQVo6fYjkCsdXINKMDINMY/+3zmAoWZjaWyRql/Mm2igB 4HMNk7VJb2qBICoPmmDZEvqh09ZmJ5qKD3qP9/wURvUFvC+elGZ+uFB4yhBvd7oPhwEn XOtXsQ+nvFUIQ3ifkiL1FSuY9Cq0pbayq4YbkCBedkFV1YrJI3cKRaGETX8NIg8HctLw kxAQ== X-Gm-Message-State: AOAM530Kw4cSosdZ7FcAa0blSo2Gl4oko+VaRVjkhUA4h9lkQW4Vmjc5 851GmT3sswQ8JIG0MA3DQI8= X-Google-Smtp-Source: ABdhPJwhWyodOd/uAQvQlNG62LLni4PUC0YD66orwGyy0YIEInb/of2VZxEC9Cj74LLpsTo32OMzXw== X-Received: by 2002:adf:f7c3:: with SMTP id a3mr4023292wrq.253.1622820044074; Fri, 04 Jun 2021 08:20:44 -0700 (PDT) Received: from ?IPv6:2001:8a0:f932:6a00:46bc:d03b:7b3a:2227? ([2001:8a0:f932:6a00:46bc:d03b:7b3a:2227]) by smtp.gmail.com with ESMTPSA id k16sm5829167wmr.42.2021.06.04.08.20.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jun 2021 08:20:43 -0700 (PDT) Subject: Re: [PATCHv3 1/2] Initial TUI mouse support From: Pedro Alves To: Hannes Domani , Hannes Domani via Gdb-patches , Tom Tromey References: <20210603151453.15248-1-ssbssa.ref@yahoo.de> <20210603151453.15248-1-ssbssa@yahoo.de> <87r1hhoi03.fsf@tromey.com> <1760297979.5212997.1622816480782@mail.yahoo.com> Message-ID: Date: Fri, 4 Jun 2021 16:20:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <1760297979.5212997.1622816480782@mail.yahoo.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-06-04 3:21 p.m., Hannes Domani via Gdb-patches wrote: > Am Freitag, 4. Juni 2021, 15:51:27 MESZ hat Tom Tromey Folgendes geschrieben: > >>>>>>> "Hannes" == Hannes Domani via Gdb-patches writes: >> >> Hannes> Implements an overridable tui_win_info::click method whose arguments >> Hannes> are the mouse coordinates inside the specific window, and the mouse >> Hannes> button clicked. >> >> Hannes> And if the curses implementation supports 5 buttons, the 4th and 5th >> Hannes> buttons are used for scrolling. >> >> Hannes> 2021-06-03  Hannes Domani  >> >> Hannes>     * ser-mingw.c (console_select_thread): Handle MOUSE_EVENT. >> Hannes>     * tui/tui-data.h (struct tui_win_info): Add click function. >> Hannes>     * tui/tui-io.c (tui_prep_terminal): Enable mouse events. >> Hannes>     (tui_deprep_terminal): Disable mouse events. >> Hannes>     (tui_dispatch_ctrl_char): Handle KEY_MOUSE. >> Hannes>     * tui/tui.c (tui_disable): Disable mouse events. >> >> Looks good.  Thank you again. > > Pushed both, thanks. > Yay, mouse support finally. Thank you! Don't we need a NEWS entry, though? Pedro Alves