From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>,
Alan Hayward <Alan.Hayward@arm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>, nd <nd@arm.com>
Subject: Re: Request for 8.2, SVE cores && adding SVE to NEWS file etc
Date: Tue, 21 Aug 2018 14:34:00 -0000 [thread overview]
Message-ID: <ca6212dc-1478-c3f6-c5d3-5bcdb656d150@redhat.com> (raw)
In-Reply-To: <20180821131646.GB24065@adacore.com>
On 08/21/2018 02:16 PM, Joel Brobecker wrote:
>> Thereâs a simple enough change to the args of a common function. And then everything
>> else is self contained. Iâd break it down into:
>>
>> dbd534fee4 5 days ago Alan Hayward Rename size in get_core_register_sectio
>> - Rename of single variable in common function. Obvious change, no risk.
>>
>> a616bb9450 2 days ago Alan Hayward Split size in regset section iterators
>> - Mechanical change across every tdep file (adds a new third arg, which is a
>> duplicate of the second arg). Very minor risk on any target that there might
>> be a copy/paste error that hasn't been spotted (just needs a triple check of
>> the diff again when merging). Minor risk that I've missed a tdep file that
>> doesn't get built into a target-all build (causing a build error which Iâd
>> hope would have been spotted by now).
>>
>> b7fd65b9dc 2 days ago Alan Hayward Detect SVE when reading aarch64 core files
>> 0c76e06d5c 2 days ago Alan Hayward Parse SVE registers in aarch64 core file reading/writing
>> - Limited to reading/writing Aarch64 (SVE and non-SVE) Linux cores on either
>> a Aarch64 Linux build or target-all build. SVE code is seperated from
>> standard aarch64 code. So to go wrong on non-SVE, the code would first
>> have to incorrectly detect the presence of SVE.
>
> I took a look at the patches, and I agree they look sufficiently
> self-contained that they should be OK for inclusion in 8.2. Give
> Pedro a few days to comment as well, just in case, but otherwise,
> it is OK for me to backport.
I have no further comments. Fine with me to go ahead.
Thanks,
Pedro Alves
prev parent reply other threads:[~2018-08-21 14:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 9:31 Alan Hayward
2018-08-16 16:17 ` Pedro Alves
2018-08-17 9:26 ` Alan Hayward
2018-08-21 13:16 ` Joel Brobecker
2018-08-21 14:34 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca6212dc-1478-c3f6-c5d3-5bcdb656d150@redhat.com \
--to=palves@redhat.com \
--cc=Alan.Hayward@arm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox