From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25376 invoked by alias); 21 Aug 2018 14:34:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25353 invoked by uid 89); 21 Aug 2018 14:34:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Aug 2018 14:34:45 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CE94A77741; Tue, 21 Aug 2018 14:34:43 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id ED97A63F37; Tue, 21 Aug 2018 14:34:42 +0000 (UTC) Subject: Re: Request for 8.2, SVE cores && adding SVE to NEWS file etc To: Joel Brobecker , Alan Hayward References: <843fee7a-1738-4147-256f-e1fc7950fe18@redhat.com> <3D0DD287-65D9-4D1B-A9EE-67E202B2FF6A@arm.com> <20180821131646.GB24065@adacore.com> Cc: GDB Patches , nd From: Pedro Alves Message-ID: Date: Tue, 21 Aug 2018 14:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180821131646.GB24065@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-08/txt/msg00481.txt.bz2 On 08/21/2018 02:16 PM, Joel Brobecker wrote: >> There’s a simple enough change to the args of a common function. And then everything >> else is self contained. I’d break it down into: >> >> dbd534fee4 5 days ago Alan Hayward Rename size in get_core_register_sectio >> - Rename of single variable in common function. Obvious change, no risk. >> >> a616bb9450 2 days ago Alan Hayward Split size in regset section iterators >> - Mechanical change across every tdep file (adds a new third arg, which is a >> duplicate of the second arg). Very minor risk on any target that there might >> be a copy/paste error that hasn't been spotted (just needs a triple check of >> the diff again when merging). Minor risk that I've missed a tdep file that >> doesn't get built into a target-all build (causing a build error which I’d >> hope would have been spotted by now). >> >> b7fd65b9dc 2 days ago Alan Hayward Detect SVE when reading aarch64 core files >> 0c76e06d5c 2 days ago Alan Hayward Parse SVE registers in aarch64 core file reading/writing >> - Limited to reading/writing Aarch64 (SVE and non-SVE) Linux cores on either >> a Aarch64 Linux build or target-all build. SVE code is seperated from >> standard aarch64 code. So to go wrong on non-SVE, the code would first >> have to incorrectly detect the presence of SVE. > > I took a look at the patches, and I agree they look sufficiently > self-contained that they should be OK for inclusion in 8.2. Give > Pedro a few days to comment as well, just in case, but otherwise, > it is OK for me to backport. I have no further comments. Fine with me to go ahead. Thanks, Pedro Alves