Re: [PATCH] gdb: fix incorrect search domain in find_function_in_inferior

[Abhay Kandpal <abhay@linux.ibm.com>]

[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]

Hi Tom,

I see two more from the same commit on powerpc64le-linux:

FAIL: gdb.compile/compile.exp: expect no 5
FAIL: gdb.compile/compile-cplus.exp: expect 5

Bisected to 32090b27e92 as well.  I sent the details to the
mailing list yesterday and have also added them to PR 34602.

Thanks,
Abhay



On 08/09/26 04:00, Tom de Vries wrote:
> On 9/4/26 11:54 AM, Andrew Burgess wrote:
>> Tom Tromey <tom@tromey.com> writes:
>>
>>>>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
>>>
>>> Andrew> The problem I see here is that the full symbol search uses
>>> Andrew> SEARCH_TYPE_DOMAIN, and has done since commit:
>>> Andrew>   commit ccf41c248737eb6650211481366c4e1156ce01ae
>>> Andrew>   Date:   Thu Mar 30 23:00:26 2023 -0600
>>> Andrew>       Use domain_search_flags in lookup_symbol et al
>>>
>>> Sorry about that.  I guess it worked by falling back to minsyms?
>>
>> Exactly.
>>
>>>
>>> I think this is ok.  Thank you.
>>> Approved-By: Tom Tromey <tom@tromey.com>
>>
>> Pushed.
>
> Hi,
>
> I see (at least two) regressions that bisect to this patch.
>
> I've reported this here ( 
> https://sourceware.org/bugzilla/show_bug.cgi?id=34602 ).
>
> I'll do a full test run to see if I find anything else.
>
> Thanks,
> - Tom
>

[-- Attachment #2: Type: text/html, Size: 3391 bytes --]