Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Andrew Burgess <aburgess@redhat.com>, Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: fix incorrect search domain in find_function_in_inferior
Date: Tue, 8 Sep 2026 00:30:59 +0200	[thread overview]
Message-ID: <c56ce097-098f-4148-a71d-0b09862548d7@suse.de> (raw)
In-Reply-To: <87h5k5s5nc.fsf@redhat.com>

On 9/4/26 11:54 AM, Andrew Burgess wrote:
> Tom Tromey <tom@tromey.com> writes:
> 
>>>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
>>
>> Andrew> The problem I see here is that the full symbol search uses
>> Andrew> SEARCH_TYPE_DOMAIN, and has done since commit:
>> Andrew>   commit ccf41c248737eb6650211481366c4e1156ce01ae
>> Andrew>   Date:   Thu Mar 30 23:00:26 2023 -0600
>> Andrew>       Use domain_search_flags in lookup_symbol et al
>>
>> Sorry about that.  I guess it worked by falling back to minsyms?
> 
> Exactly.
> 
>>
>> I think this is ok.  Thank you.
>> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Pushed.

Hi,

I see (at least two) regressions that bisect to this patch.

I've reported this here ( 
https://sourceware.org/bugzilla/show_bug.cgi?id=34602 ).

I'll do a full test run to see if I find anything else.

Thanks,
- Tom


  reply	other threads:[~2026-09-07 22:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02 16:16 Andrew Burgess
2026-09-03 20:23 ` Tom Tromey
2026-09-04  9:54   ` Andrew Burgess
2026-09-07 22:30     ` Tom de Vries [this message]
2026-09-08  5:52       ` Tom de Vries
2026-09-08 15:28         ` Andrew Burgess
2026-09-08  5:55       ` Abhay Kandpal
2026-09-08 16:27         ` Andrew Burgess
2026-09-08 17:23           ` Tom de Vries
2026-09-07 18:39 ` Abhay Kandpal
2026-09-08  8:05   ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c56ce097-098f-4148-a71d-0b09862548d7@suse.de \
    --to=tdevries@suse.de \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox