From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simark@simark.ca>,
Simon Marchi <simon.marchi@efficios.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix indentation (and clang warning) in c-lang.c
Date: Tue, 17 Dec 2019 19:24:00 -0000 [thread overview]
Message-ID: <c9131a84-e556-b7b1-e489-818ae866161f@redhat.com> (raw)
In-Reply-To: <ee0d94f5-0fa4-7667-68fc-29cb8a905b9a@simark.ca>
On 12/16/19 11:50 PM, Simon Marchi wrote:
> On 2019-12-16 6:36 p.m., Simon Marchi wrote:
>> I see this warning when building with clang:
>
> I meant to add the clang version to the commit message, but forgot, I'll
> add it locally. The version is (daily build from apt.llvm.org):
>
> $ clang++-10 --version
> clang version 10.0.0-+20191211091425+f99297176cd-1~exp1~20191211082036.1372
Curious. Are you saying that that changed recently in clang? I wonder
whether clang's warning catches this case on purpose, or whether it's
a regression. I asked David Malcolm, who added that warning to GCC, and he
said that GCC's implementation respects tab stops, so small numbers of
leading spaces before a tab are effectively ignored.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2019-12-17 19:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 23:36 Simon Marchi
2019-12-16 23:50 ` Simon Marchi
2019-12-17 19:24 ` Pedro Alves [this message]
2019-12-17 19:39 ` Simon Marchi
2019-12-17 19:41 ` Pedro Alves
2019-12-17 19:53 ` Simon Marchi
2019-12-18 18:28 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9131a84-e556-b7b1-e489-818ae866161f@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox