From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4018 invoked by alias); 17 Dec 2019 19:24:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4005 invoked by uid 89); 17 Dec 2019 19:24:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (205.139.110.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Dec 2019 19:24:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576610688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JtCGwIyC6OCfMSal5QvTNXE/EW78cCH08PJq1y4aq2I=; b=NuMtclJmc3sRI0RsoDilmsauoBo+61tsPd9jur34N0w5SXh2cK7hJ5hfIe4IibOAzpeoV8 lA3bpFH5fTwdgcPAAAxgGPTEmHrMzcQ5glukGi8fhfscfCCVcSD2H2BP9HgxCVvO/vZYRR yWPI+Yj1nqoIN3g+Qnk8jmDLKX4bQsQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-380-WCO_tgvjMVuXBFfrw1A7Nw-1; Tue, 17 Dec 2019 14:24:46 -0500 Received: by mail-wm1-f69.google.com with SMTP id t17so501761wmi.7 for ; Tue, 17 Dec 2019 11:24:46 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id k8sm26914110wrl.3.2019.12.17.11.24.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Dec 2019 11:24:44 -0800 (PST) Subject: Re: [PATCH] Fix indentation (and clang warning) in c-lang.c To: Simon Marchi , Simon Marchi , gdb-patches@sourceware.org References: <20191216233637.29925-1-simon.marchi@efficios.com> From: Pedro Alves Message-ID: Date: Tue, 17 Dec 2019 19:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-12/txt/msg00751.txt.bz2 On 12/16/19 11:50 PM, Simon Marchi wrote: > On 2019-12-16 6:36 p.m., Simon Marchi wrote: >> I see this warning when building with clang: > > I meant to add the clang version to the commit message, but forgot, I'll > add it locally. The version is (daily build from apt.llvm.org): > > $ clang++-10 --version > clang version 10.0.0-+20191211091425+f99297176cd-1~exp1~20191211082036.1372 Curious. Are you saying that that changed recently in clang? I wonder whether clang's warning catches this case on purpose, or whether it's a regression. I asked David Malcolm, who added that warning to GCC, and he said that GCC's implementation respects tab stops, so small numbers of leading spaces before a tab are effectively ignored. Thanks, Pedro Alves