From: Simon Marchi <simon.marchi@polymtl.ca>
To: Keith Seitz <keiths@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 5/9] Change decode_compound_collector to use std::vector
Date: Mon, 20 Aug 2018 01:20:00 -0000 [thread overview]
Message-ID: <c75a776b7fe800f431abf7a0c98bfe9c@polymtl.ca> (raw)
In-Reply-To: <9675ef7a-9d3c-5dfb-3f56-e43d80eb02d5@redhat.com>
On 2018-08-17 14:04, Keith Seitz wrote:
> @@ -3514,12 +3511,10 @@ public:
> htab_delete (m_unique_syms);
> }
>
> - /* Releases ownership of the collected symbols and returns them. */
> - VEC (symbolp) *release_symbols ()
> + /* Return all symbols collected. */
> + std::vector<symbol *> release_symbols ()
> {
> - VEC (symbolp) *res = m_symbols;
> - m_symbols = NULL;
> - return res;
> + return std::move (m_symbols);
I've always read that it was bad to use std::move on a return value:
https://diego.assencio.com/?index=f57f25fd5a187c70fc7f34fcf5374773
though in this case it seems like the right thing to do.
Simon
next prev parent reply other threads:[~2018-08-20 1:20 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 23:25 [PATCH 0/9] C++ Support for Compile Keith Seitz
2018-08-10 23:25 ` [PATCH 3/9] Change `label_symbols' to std::vector in linespec.c structures Keith Seitz
2018-08-11 14:50 ` Tom Tromey
2018-08-10 23:25 ` [PATCH 1/9] Change `file_symtabs' to std::vector Keith Seitz
2018-08-11 14:47 ` Tom Tromey
2018-08-17 17:56 ` Keith Seitz
2018-08-28 17:30 ` Tom Tromey
2018-08-10 23:25 ` [PATCH 2/9] Change `function_symbols' " Keith Seitz
2018-08-11 14:49 ` Tom Tromey
2018-08-17 17:59 ` Keith Seitz
2018-08-28 17:43 ` Tom Tromey
2018-08-10 23:31 ` [PATCH 7/9] Use block_symbol_d in linespec APIs Keith Seitz
2018-08-11 15:05 ` Tom Tromey
2018-08-17 18:04 ` Keith Seitz
2018-08-10 23:31 ` [PATCH 6/9] Remove VEC definitions from linespec.c Keith Seitz
2018-08-11 15:03 ` Tom Tromey
2018-08-10 23:32 ` [PATCH 9/9] C++ compile support Keith Seitz
2018-08-11 7:22 ` Eli Zaretskii
2018-08-17 17:51 ` Keith Seitz
2018-08-17 18:57 ` Eli Zaretskii
2018-08-20 17:02 ` Keith Seitz
2018-08-12 0:17 ` Tom Tromey
2018-08-17 18:26 ` Keith Seitz
2018-08-28 17:52 ` Tom Tromey
2018-08-29 22:32 ` Keith Seitz
2021-03-24 1:04 ` Simon Marchi via Gdb-patches
2021-03-24 14:51 ` Keith Seitz via Gdb-patches
2021-03-24 15:06 ` Simon Marchi via Gdb-patches
2021-03-24 20:49 ` Keith Seitz via Gdb-patches
2021-04-01 18:03 ` Tom Tromey
2021-04-01 18:07 ` Luis Machado via Gdb-patches
2021-04-01 19:36 ` Keith Seitz via Gdb-patches
2018-08-10 23:32 ` [PATCH 5/9] Change decode_compound_collector to use std::vector Keith Seitz
2018-08-11 15:02 ` Tom Tromey
2018-08-17 18:04 ` Keith Seitz
2018-08-20 1:20 ` Simon Marchi [this message]
2018-08-20 13:28 ` Tom Tromey
2018-08-20 14:03 ` Simon Marchi
2018-08-28 17:46 ` Tom Tromey
2018-08-10 23:32 ` [PATCH 4/9] Change `minimal_symbols' to std::vector in linespec.c structures Keith Seitz
2018-08-11 15:01 ` Tom Tromey
2018-08-17 18:00 ` Keith Seitz
2018-08-28 17:44 ` Tom Tromey
2018-08-10 23:34 ` [PATCH 8/9] Add new search_symbols_multiple API Keith Seitz
2018-08-11 20:49 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c75a776b7fe800f431abf7a0c98bfe9c@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox