From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112282 invoked by alias); 20 Aug 2018 01:20:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112270 invoked by uid 89); 20 Aug 2018 01:20:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_05,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=H*UA:Roundcube, H*u:Roundcube, H*u:Webmail, collected X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Aug 2018 01:20:08 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w7K1K1MD012230 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 19 Aug 2018 21:20:06 -0400 Received: by simark.ca (Postfix, from userid 112) id 587F61EF38; Sun, 19 Aug 2018 21:20:01 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id DBB1C1E183; Sun, 19 Aug 2018 21:19:57 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 20 Aug 2018 01:20:00 -0000 From: Simon Marchi To: Keith Seitz Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 5/9] Change decode_compound_collector to use std::vector In-Reply-To: <9675ef7a-9d3c-5dfb-3f56-e43d80eb02d5@redhat.com> References: <20180810232534.481-1-keiths@redhat.com> <20180810232534.481-6-keiths@redhat.com> <87pnypt086.fsf@tromey.com> <9675ef7a-9d3c-5dfb-3f56-e43d80eb02d5@redhat.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00446.txt.bz2 On 2018-08-17 14:04, Keith Seitz wrote: > @@ -3514,12 +3511,10 @@ public: > htab_delete (m_unique_syms); > } > > - /* Releases ownership of the collected symbols and returns them. */ > - VEC (symbolp) *release_symbols () > + /* Return all symbols collected. */ > + std::vector release_symbols () > { > - VEC (symbolp) *res = m_symbols; > - m_symbols = NULL; > - return res; > + return std::move (m_symbols); I've always read that it was bad to use std::move on a return value: https://diego.assencio.com/?index=f57f25fd5a187c70fc7f34fcf5374773 though in this case it seems like the right thing to do. Simon