From: Pedro Alves <palves@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>, Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Change frame_filter_flags to use DEF_ENUM_FLAGS_TYPE
Date: Fri, 28 Apr 2017 10:56:00 -0000 [thread overview]
Message-ID: <c69c2375-8b5c-fbfe-d9c8-52fe2e8f6539@redhat.com> (raw)
In-Reply-To: <8737cttcxh.fsf@redhat.com>
On 04/28/2017 04:43 AM, Sergio Durigan Junior wrote:
> On Thursday, April 27 2017, Tom Tromey wrote:
>
>> This changes frame_filter_flags to use DEF_ENUM_FLAGS_TYPE, and
>> updates all the uses. It also changes the enum constants to use <<,
>> as suggested by Sergio.
>
> Hey, that's awesome, Tom. Thanks for doing this; also, very good to use
> DEF_ENUM_FLAGS_TYPE. This will make it prettier when printing these
> values on GDB.
(and catch misuses at compile time.)
>
> LGTM.
To me too.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-04-28 10:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 23:17 Tom Tromey
2017-04-28 3:44 ` Sergio Durigan Junior
2017-04-28 10:56 ` Pedro Alves [this message]
2017-04-28 13:47 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c69c2375-8b5c-fbfe-d9c8-52fe2e8f6539@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox