From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84692 invoked by alias); 28 Apr 2017 10:56:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84660 invoked by uid 89); 28 Apr 2017 10:56:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=awesome, Thursday, thursday, hey X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Apr 2017 10:56:45 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D36F33B707; Fri, 28 Apr 2017 10:56:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D36F33B707 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com D36F33B707 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2FF2B996D8; Fri, 28 Apr 2017 10:56:43 +0000 (UTC) Subject: Re: [RFA] Change frame_filter_flags to use DEF_ENUM_FLAGS_TYPE To: Sergio Durigan Junior , Tom Tromey References: <20170427231728.27581-1-tom@tromey.com> <8737cttcxh.fsf@redhat.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Fri, 28 Apr 2017 10:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <8737cttcxh.fsf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00768.txt.bz2 On 04/28/2017 04:43 AM, Sergio Durigan Junior wrote: > On Thursday, April 27 2017, Tom Tromey wrote: > >> This changes frame_filter_flags to use DEF_ENUM_FLAGS_TYPE, and >> updates all the uses. It also changes the enum constants to use <<, >> as suggested by Sergio. > > Hey, that's awesome, Tom. Thanks for doing this; also, very good to use > DEF_ENUM_FLAGS_TYPE. This will make it prettier when printing these > values on GDB. (and catch misuses at compile time.) > > LGTM. To me too. Thanks, Pedro Alves