From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Factor out mi_ui_out instantiation logic
Date: Wed, 13 Mar 2019 17:34:00 -0000 [thread overview]
Message-ID: <c660bd1f-b4ad-9f62-4c73-effcb4d1b76a@polymtl.ca> (raw)
In-Reply-To: <7017ba96-406a-d510-2456-a4289e30ecca@redhat.com>
On 2019-03-13 11:30 a.m., Pedro Alves wrote:
> On 03/13/2019 03:02 AM, Simon Marchi wrote:
>
>> gdb/ChangeLog:
>>
>> * mi/mi-out.h (mi_out_new): Change parameter to const char *.
>> * mi/mi-out.c (mi_out_new): Change parameter to const char *,
>> instantiate mi_ui_out based on interpreter name.
>> * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
>
> LGTM.
>
> Thanks,
> Pedro Alves
>
Thanks, I pushed it.
Simon
prev parent reply other threads:[~2019-03-13 17:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 3:02 Simon Marchi
2019-03-13 15:31 ` Pedro Alves
2019-03-13 17:34 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c660bd1f-b4ad-9f62-4c73-effcb4d1b76a@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox