From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77129 invoked by alias); 13 Mar 2019 17:34:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 77118 invoked by uid 89); 13 Mar 2019 17:34:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=am, UD:a.m, a.m X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Mar 2019 17:34:07 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x2DHXwRO006296 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Mar 2019 13:34:03 -0400 Received: from [172.16.0.89] (192-222-157-41.qc.cable.ebox.net [192.222.157.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 700221E182; Wed, 13 Mar 2019 13:33:58 -0400 (EDT) Subject: Re: [PATCH] Factor out mi_ui_out instantiation logic To: Pedro Alves , gdb-patches@sourceware.org References: <20190313030218.21452-1-simon.marchi@polymtl.ca> <7017ba96-406a-d510-2456-a4289e30ecca@redhat.com> From: Simon Marchi Message-ID: Date: Wed, 13 Mar 2019 17:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <7017ba96-406a-d510-2456-a4289e30ecca@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00276.txt.bz2 On 2019-03-13 11:30 a.m., Pedro Alves wrote: > On 03/13/2019 03:02 AM, Simon Marchi wrote: > >> gdb/ChangeLog: >> >> * mi/mi-out.h (mi_out_new): Change parameter to const char *. >> * mi/mi-out.c (mi_out_new): Change parameter to const char *, >> instantiate mi_ui_out based on interpreter name. >> * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new. > > LGTM. > > Thanks, > Pedro Alves > Thanks, I pushed it. Simon