From: Simon Marchi <simark@simark.ca>
To: Matthieu Longo <matthieu.longo@arm.com>, gdb-patches@sourceware.org
Cc: Luis Machado <luis.machado@amd.com>,
Luis Machado <luis.machado.foss@gmail.com>,
Thiago Jung Bauermann <thiago.bauermann@linaro.org>
Subject: Re: [PATCH v1 1/2] gdb: rename any_thread_of_inferior to any_non_exited_thread_of_inferior
Date: Thu, 20 Aug 2026 11:37:23 -0400 [thread overview]
Message-ID: <c62ace82-a089-4b30-9ba9-cca3353eb915@simark.ca> (raw)
In-Reply-To: <20260728143317.245389-2-matthieu.longo@arm.com>
On 7/28/26 10:33 AM, Matthieu Longo wrote:
> The name any_thread_of_inferior suggests that the function may return
> any thread of the inferior. In practice, it only returns a non-exited
> thread.
>
> Rename it to any_non_exited_thread_of_inferior to better reflect its
> behavior. This is a preparatory change for the following patch, which
> adds another helper with similar semantics.
>
> Suggested-by: Simon Marchi <simark@simark.ca>
> [1]: https://inbox.sourceware.org/gdb-patches/590655c1-abed-4a16-b8cc
> -762f1d8e6093@simark.ca/
The trailer lines should be the very last thing of the commit message,
so either move this [1] line or remove it.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
next prev parent reply other threads:[~2026-08-20 15:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 14:33 [PATCH v1 0/2] gdb: fix for bug 31207 Matthieu Longo
2026-07-28 14:33 ` [PATCH v1 1/2] gdb: rename any_thread_of_inferior to any_non_exited_thread_of_inferior Matthieu Longo
2026-08-20 15:37 ` Simon Marchi [this message]
2026-08-24 14:17 ` Matthieu Longo
2026-07-28 14:33 ` [PATCH v1 2/2] gdb: rely on the first non-exited thread TPID when reading Linux procfs files Matthieu Longo
2026-08-03 4:48 ` Thiago Jung Bauermann
2026-08-13 15:13 ` Matthieu Longo
2026-08-20 15:48 ` Simon Marchi
2026-08-24 15:29 ` Matthieu Longo
2026-08-24 16:25 ` Matthieu Longo
2026-08-24 16:27 ` Matthieu Longo
2026-08-20 11:09 ` [PATCH v1 0/2] gdb: fix for bug 31207 Matthieu Longo
2026-08-21 15:39 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c62ace82-a089-4b30-9ba9-cca3353eb915@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado.foss@gmail.com \
--cc=luis.machado@amd.com \
--cc=matthieu.longo@arm.com \
--cc=thiago.bauermann@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox