From: Keith Seitz <keiths@redhat.com>
To: Tom Tromey <tom@tromey.com>, Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/2] Fix ODR violations in regformat target descriptions
Date: Tue, 7 Jul 2026 12:49:44 -0700 [thread overview]
Message-ID: <c602dab8-b02b-4b20-a420-e658db750207@redhat.com> (raw)
In-Reply-To: <87a4sr4vvj.fsf@tromey.com>
On 6/18/26 10:10 AM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>
> Simon> Other than the little nit I sent on patch 1, this series LGTM (although
> Simon> I still don't fully understand why regdat exists and how it works).
>
> I was curious about this as well. Like, how hard is it to remove this?
> Since IIUC it's an obsolete way of writing a target description.
From what I understand while hacking at this, you are correct. It is a
very outdated way of writing a target description. The modern way is via
XML/features.
I asked Claude to explain what would it would take to get rid of this
and update everything. Unless it is completely fabricating its response
(and I have not read anything to suggest such), it is a non-trivial
amount of work.
The short of it is, there are six "legacy" targets with no XML backing
whatsoever. These targets include padding registers, integer-only
registers (missing FP), and other peculiarities which may be non-trivial
to implement completely and/or correctly. [Or not -- I've not dug *that*
deeply into it.]
There are an additional 42 targets which are XML-backed that would also
require some conversion. Testing all of these will be a nightmare.
If you'd like, I can file a bug and add the complete Claude response.
Just let me know.
In the meantime, I've pushed these patches. Thank you to you and Simon
for your reviews.
Keith
prev parent reply other threads:[~2026-07-07 19:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 14:23 Keith Seitz
2026-06-18 14:23 ` [PATCH 1/2] regdat.sh: generate const_target_desc_up for register descriptions Keith Seitz
2026-06-18 15:52 ` Simon Marchi
2026-06-18 14:23 ` [PATCH 2/2] [gdbserver] Use const_target_desc_up for regformat tdescs Keith Seitz
2026-06-18 15:57 ` [PATCH 0/2] Fix ODR violations in regformat target descriptions Simon Marchi
2026-06-18 17:10 ` Tom Tromey
2026-07-07 19:49 ` Keith Seitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c602dab8-b02b-4b20-a420-e658db750207@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox