From: Simon Marchi <simark@simark.ca>
To: Keith Seitz <keiths@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] regdat.sh: generate const_target_desc_up for register descriptions
Date: Thu, 18 Jun 2026 11:52:02 -0400 [thread overview]
Message-ID: <bb9e05a6-72f3-4b5c-98a0-bc89809178f5@simark.ca> (raw)
In-Reply-To: <3b7d26075e66f53cafc44f571165de54527d923b.1781792506.git.keiths@redhat.com>
On 2026-06-18 10:23, Keith Seitz wrote:
> @@ -195,12 +194,12 @@ echo
> osabi_enum=$(grep "${osabi}" "$2" | sed 's/.*(\([^,]\+\),.*/GDB_OSABI_\1/')
>
> cat <<EOF
> - result->xmltarget = xmltarget_${name};
> + result.get ()->xmltarget = xmltarget_${name};
I don't think this .get() is needed.
Simon
next prev parent reply other threads:[~2026-06-18 15:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 14:23 [PATCH 0/2] Fix ODR violations in regformat target descriptions Keith Seitz
2026-06-18 14:23 ` [PATCH 1/2] regdat.sh: generate const_target_desc_up for register descriptions Keith Seitz
2026-06-18 15:52 ` Simon Marchi [this message]
2026-06-18 14:23 ` [PATCH 2/2] [gdbserver] Use const_target_desc_up for regformat tdescs Keith Seitz
2026-06-18 15:57 ` [PATCH 0/2] Fix ODR violations in regformat target descriptions Simon Marchi
2026-06-18 17:10 ` Tom Tromey
2026-07-07 19:49 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb9e05a6-72f3-4b5c-98a0-bc89809178f5@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox