From: Pedro Alves <palves@redhat.com>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>,
gdb-patches@sourceware.org
Subject: Re: [RFAv4 0/5] Implement | (pipe) command.
Date: Fri, 31 May 2019 14:42:00 -0000 [thread overview]
Message-ID: <c5b9ce47-31e2-3d26-00b0-d989d0ad0384@redhat.com> (raw)
In-Reply-To: <20190530142106.25487-1-philippe.waroquiers@skynet.be>
On 5/30/19 3:21 PM, Philippe Waroquiers wrote:
> Implement | (pipe) command.
>
> This patch series adds the pipe command, that allows to send the output
> of a GDB command to a shell command.
>
> This is the fourth version of the patch, handling the additional
> comments of Pedro.
> The doc, help and NEWS are changed in this fourth version, so must be
> re-reviewed.
This version looks good to me, apart for the comment I sent about NEWS.
From the nit department, in the testcase patch, in the last test,
use lowercase for "Delimiter" in the test message.
With those fixed, this is good to go. Please push.
Thanks for doing this.
Pedro Alves
next prev parent reply other threads:[~2019-05-31 14:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 14:21 Philippe Waroquiers
2019-05-30 14:21 ` [RFAv4 4/5] Test the " Philippe Waroquiers
2019-05-30 14:21 ` [RFAv4 3/5] Implement " Philippe Waroquiers
2019-05-30 14:21 ` [RFAv4 2/5] Add function execute_command_to_ui_file Philippe Waroquiers
2019-05-30 14:21 ` [RFAv4 1/5] Add previous_saved_command_line to allow a command to repeat a previous command Philippe Waroquiers
2019-05-30 14:21 ` [RFAv4 5/5] NEWS and documentation for | (pipe) command Philippe Waroquiers
2019-05-30 15:02 ` Eli Zaretskii
2019-05-31 14:39 ` Pedro Alves
2019-05-31 14:42 ` Pedro Alves [this message]
2019-05-31 15:29 ` [RFAv4 0/5] Implement " Philippe Waroquiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5b9ce47-31e2-3d26-00b0-d989d0ad0384@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=philippe.waroquiers@skynet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox