From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] python: Add Inferior.progspace property
Date: Wed, 12 Sep 2018 22:22:00 -0000 [thread overview]
Message-ID: <c4cbd1d8f85abdeea6d57dc2b6113f5c@polymtl.ca> (raw)
In-Reply-To: <87h8iujstp.fsf@tromey.com>
On 2018-09-12 17:42, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
>
> Simon> This patch adds a progspace property to the gdb.Inferior type,
> which
> Simon> allows getting the gdb.Progspace object associated to that
> inferior.
> Simon> In conjunction with the following patch, this will allow scripts
> iterate
> Simon> on objfiles associated with a particular inferior.
>
> I did this a long time ago, plus a bit more.
> I think it would be good to compare approaches.
>
> Old thread here:
> https://sourceware.org/ml/gdb-patches/2014-06/msg00616.html
>
> I rebaesd it - see the python/progspace-submit branch in my github.
> I haven't re-tested it yet.
Oh wow, that's much more complete than what I have. I also spotted some
other areas of improvement, but I know that if I try to bite too much in
one go I never finish and submit what I have. That's why I sent just
these two by themselves.
If you intend on finishing and submitting that patch I'll drop mine.
Otherwise, I'll go ahead and maybe submit yours chunk by chunk, adding
tests in the process.
As far as the gdb.Inferior.progspace part is concerned, our two versions
are essentially identical.
> Simon> While modifying py-inferior.exp, I added some checks for the
> other
> Simon> Inferior properties, when the Inferior is no longer valid. This
> doesn't
> Simon> seem tested at the moment.
>
> This could go in immediately if you were so inclined.
Ok, I'll push an obvious patch for that.
Simon
next prev parent reply other threads:[~2018-09-12 22:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 19:37 Simon Marchi
2018-09-12 19:36 ` [PATCH 3/3] python: Fix erroneous doc about gdb.objfiles() Simon Marchi
2018-09-12 21:46 ` Tom Tromey
2018-09-13 2:37 ` Eli Zaretskii
2018-09-13 2:42 ` Simon Marchi
2018-09-12 19:37 ` [PATCH 2/3] python: Add Progspace.objfiles method Simon Marchi
2018-09-12 22:01 ` Tom Tromey
2018-09-12 22:58 ` Simon Marchi
2018-09-13 4:50 ` Tom Tromey
2018-09-13 2:38 ` Eli Zaretskii
2018-09-12 21:42 ` [PATCH 1/3] python: Add Inferior.progspace property Tom Tromey
2018-09-12 22:22 ` Simon Marchi [this message]
2018-09-13 4:38 ` Tom Tromey
2018-09-13 22:16 ` Tom Tromey
2018-09-12 21:43 ` Tom Tromey
2018-09-13 2:37 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4cbd1d8f85abdeea6d57dc2b6113f5c@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox