From: Simon Marchi <simon.marchi@polymtl.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Simon Marchi <simon.marchi@ericsson.com>,
gdb-patches@sourceware.org, tom@tromey.com
Subject: Re: [PATCH 3/3] python: Fix erroneous doc about gdb.objfiles()
Date: Thu, 13 Sep 2018 02:42:00 -0000 [thread overview]
Message-ID: <69fe9a7d7d918814e46b5933153b458d@polymtl.ca> (raw)
In-Reply-To: <83r2hyktsa.fsf@gnu.org>
On 2018-09-12 22:36, Eli Zaretskii wrote:
>> From: Simon Marchi <simon.marchi@ericsson.com>
>> CC: Simon Marchi <simon.marchi@ericsson.com>
>> Date: Wed, 12 Sep 2018 15:36:17 -0400
>>
>> diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
>> index abda135e17d..a9de6bd815e 100644
>> --- a/gdb/doc/python.texi
>> +++ b/gdb/doc/python.texi
>> @@ -4104,8 +4104,9 @@ this function returns @code{None}.
>>
>> @findex gdb.objfiles
>> @defun gdb.objfiles ()
>> -Return a sequence of all the objfiles current known to @value{GDBN}.
>> -@xref{Objfiles In Python}.
>> +Return a sequence of objfiles for the current program space (and by
>> extension,
>> +for the selected inferior) @xref{Objfiles In Python} and
>> +@pxref{Progspaces In Python}.
>> @end defun
>
> "By extension" confuses me. And there should be a period before @xref
> and a comma after its closing brace.
>
> Thanks.
Hi Eli,
This changed in the v2 I just sent 5 minutes ago :).
I stole the text from an old patch of Tom, which says
This is identical to gdb.selected_inferior().progspace.objfiles() and
is included for historical compatibility.
Which makes what I was trying to say here unnecessary.
Simon
next prev parent reply other threads:[~2018-09-13 2:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 19:37 [PATCH 1/3] python: Add Inferior.progspace property Simon Marchi
2018-09-12 19:36 ` [PATCH 3/3] python: Fix erroneous doc about gdb.objfiles() Simon Marchi
2018-09-12 21:46 ` Tom Tromey
2018-09-13 2:37 ` Eli Zaretskii
2018-09-13 2:42 ` Simon Marchi [this message]
2018-09-12 19:37 ` [PATCH 2/3] python: Add Progspace.objfiles method Simon Marchi
2018-09-12 22:01 ` Tom Tromey
2018-09-12 22:58 ` Simon Marchi
2018-09-13 4:50 ` Tom Tromey
2018-09-13 2:38 ` Eli Zaretskii
2018-09-12 21:42 ` [PATCH 1/3] python: Add Inferior.progspace property Tom Tromey
2018-09-12 22:22 ` Simon Marchi
2018-09-13 4:38 ` Tom Tromey
2018-09-13 22:16 ` Tom Tromey
2018-09-12 21:43 ` Tom Tromey
2018-09-13 2:37 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69fe9a7d7d918814e46b5933153b458d@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox