Re: [PATCH] Call error_value_optimized_out from value_assign

[Tom de Vries <tdevries@suse.de>]

On 4/21/26 9:41 PM, Tom Tromey wrote:
> value_assign will throw an exception indicating that the value is
> optimized out, but it seemed better to me for it to use the utility
> function error_value_optimized_out.

Hi Tom,

LGTM.

Approved-By: Tom de Vries <tdevries@suse.de>

I wondered about the NOT_AVAILABLE_ERROR, and I think we could do 
something similar, see unverified patch below.

I'll submit it as a separate patch, after you merge this one.  I'm not 
sure if it makes sense, but given that it touches the same code, you 
could also merge it into your patch.

Thanks,
- Tom

diff --git a/gdb/valops.c b/gdb/valops.c
index 515e43ccdfa..95888d3539a 100644
--- a/gdb/valops.c
+++ b/gdb/valops.c
@@ -1228,8 +1228,7 @@ value_assign (struct value *toval, struct value 
*fromval)
  		  throw_error (OPTIMIZED_OUT_ERROR,
  			       _("value has been optimized out"));
  		if (unavail)
-		  throw_error (NOT_AVAILABLE_ERROR,
-			       _("value is not available"));
+		  error_value_not_available ();
  	      }

  	    modify_field (type, buffer, value_as_long (fromval),
diff --git a/gdb/value.c b/gdb/value.c
index 2d90780f57a..332b3c4bbc7 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -1127,6 +1127,12 @@ error_value_optimized_out (void)
    throw_error (OPTIMIZED_OUT_ERROR, _("value has been optimized out"));
  }

+void
+error_value_not_available (void)
+{
+  throw_error (OPTIMIZED_OUT_ERROR, _("value is not available"));
+}
+
  void
  value::require_not_optimized_out () const
  {
@@ -1144,7 +1150,7 @@ void
  value::require_available () const
  {
    if (!m_unavailable.empty ())
-    throw_error (NOT_AVAILABLE_ERROR, _("value is not available"));
+    error_value_not_available ();
  }

  gdb::array_view<const gdb_byte>
diff --git a/gdb/value.h b/gdb/value.h
index 201db773a84..0267ee804e1 100644
--- a/gdb/value.h
+++ b/gdb/value.h
@@ -987,6 +987,10 @@ struct lval_funcs

  [[noreturn]] extern void error_value_optimized_out ();

+/* Throw an error complaining that the value is not available.  */
+
+[[noreturn]] extern void error_value_not_available ();
+
  /* Pointer to internal variable.  */
  #define VALUE_INTERNALVAR(val) (*((val)->deprecated_internalvar_hack ()))