Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] Call error_value_optimized_out from value_assign
Date: Fri, 24 Apr 2026 08:37:33 -0600	[thread overview]
Message-ID: <87fr4kpgpe.fsf@tromey.com> (raw)
In-Reply-To: <c4c7cf29-b088-480c-903f-eaccf7b23d13@suse.de> (Tom de Vries's message of "Fri, 24 Apr 2026 11:37:19 +0200")

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> Approved-By: Tom de Vries <tdevries@suse.de>

Thanks.

Tom> I wondered about the NOT_AVAILABLE_ERROR, and I think we could do
Tom> something similar, see unverified patch below.

Makes sense.

Tom> I'll submit it as a separate patch, after you merge this one.  I'm not
Tom> sure if it makes sense, but given that it touches the same code, you
Tom> could also merge it into your patch.

Tom> +void
Tom> +error_value_not_available (void)
Tom> +{
Tom> +  throw_error (OPTIMIZED_OUT_ERROR, _("value is not available"));

Should use NOT_AVAILABLE_ERROR here.

Also (void) is a C-ism.

Tom

  reply	other threads:[~2026-04-24 14:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-21 19:41 Tom Tromey
2026-04-24  9:37 ` Tom de Vries
2026-04-24 14:37   ` Tom Tromey [this message]
2026-04-24 17:37     ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fr4kpgpe.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox