From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, John Baldwin <jhb@FreeBSD.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Implement the skip_solib_resolver gdbarch hook for FreeBSD architectures.
Date: Sat, 11 Jul 2020 17:18:34 -0400 [thread overview]
Message-ID: <c432eedd-68c0-86e6-ad0d-0156617c6bb5@simark.ca> (raw)
In-Reply-To: <87v9itrhe0.fsf@tromey.com>
On 2020-07-11 3:17 p.m., Tom Tromey wrote:
>>>>>> "John" == John Baldwin <jhb@FreeBSD.org> writes:
>
> John> +CORE_ADDR
> John> +mips_fbsd_skip_solib_resolver (struct gdbarch *gdbarch, CORE_ADDR pc)
> John> +{
>
> I think this should be "static".
>
> Tom
>
Oh right, and that should generate a warning, doesn't it?
next prev parent reply other threads:[~2020-07-11 21:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-11 16:14 John Baldwin
2020-07-11 18:54 ` Simon Marchi
2020-07-17 18:50 ` John Baldwin
2020-07-17 22:59 ` [PATCH v2] " John Baldwin
2020-07-19 15:47 ` Simon Marchi
2020-07-11 19:17 ` [PATCH] " Tom Tromey
2020-07-11 21:18 ` Simon Marchi [this message]
2020-07-11 21:56 ` Tom Tromey
2020-07-17 18:15 ` John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c432eedd-68c0-86e6-ad0d-0156617c6bb5@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox