From: John Baldwin <jhb@FreeBSD.org>
To: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Implement the skip_solib_resolver gdbarch hook for FreeBSD architectures.
Date: Fri, 17 Jul 2020 11:50:28 -0700 [thread overview]
Message-ID: <4ae8ff57-66bd-0e26-5bdf-46aabf4699a3@FreeBSD.org> (raw)
In-Reply-To: <10b22abc-f273-7a04-fc2f-2d798d8cb03f@simark.ca>
On 7/11/20 11:54 AM, Simon Marchi wrote:
> On 2020-07-11 12:14 p.m., John Baldwin wrote:
> Just curious, why do you have to validate that `BMSYMBOL_VALUE_ADDRESS (msym) == pc`,
> in which case would it not be true?
I will fix all the style things. Apart from the missing space before paren they
are all just copy-pasta from the sol2, nbsd, and obsd versions. (The glibc version
is quite a bit different).
All of the other versions do the == pc check. I'm not quite sure. Perhaps it is
so that if you are intentionally single stepping through the PLT stub to debug it
(as I have sometimes had to do) you can still do that without it jumping to the end,
but that if you are doing stepping at the caller's frame it will skip over the
stub.
--
John Baldwin
next prev parent reply other threads:[~2020-07-17 18:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-11 16:14 John Baldwin
2020-07-11 18:54 ` Simon Marchi
2020-07-17 18:50 ` John Baldwin [this message]
2020-07-17 22:59 ` [PATCH v2] " John Baldwin
2020-07-19 15:47 ` Simon Marchi
2020-07-11 19:17 ` [PATCH] " Tom Tromey
2020-07-11 21:18 ` Simon Marchi
2020-07-11 21:56 ` Tom Tromey
2020-07-17 18:15 ` John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ae8ff57-66bd-0e26-5bdf-46aabf4699a3@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox