From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/5] Introduce specialized versions of gdbpy_ref
Date: Tue, 24 Jan 2017 16:18:00 -0000 [thread overview]
Message-ID: <c32835f19e288ddde9a51e51b5377e18@polymtl.ca> (raw)
In-Reply-To: <8737g85u9h.fsf@tromey.com>
On 2017-01-24 10:53, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
>
> Simon> We currently have a single type, gdbpy_ref, which holds a
> Simon> reference to a PyObject*. This means that if we want to wrap an
> Simon> inferior_object* (which is a sub-class-ish of PyObject), we need
> to cast
> Simon> it when constructing the reference:
>
> This was the subject of this patch:
>
> https://sourceware.org/ml/gdb-patches/2017-01/msg00277.html
>
> I applied it all over the Python layer.
>
> Tom
Ah damn, shame on me for missing it. At least doing it by myself made
me learn a lot :). I'll take a look at that series.
There might still be some bits relevant in the current series, like the
bug fix in patch 5 (unless you also addressed it). I'll re-evaluate it
once your series is in.
Simon
next prev parent reply other threads:[~2017-01-24 16:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 22:43 [PATCH 0/5] Improve Python Inferior reference handling + fix a bug Simon Marchi
2017-01-23 22:43 ` [PATCH 4/5] Make Python inferior-related internal functions return a gdbpy_inf_ref Simon Marchi
2017-01-24 16:15 ` Simon Marchi
2017-02-09 12:30 ` Pedro Alves
2017-02-09 16:39 ` Simon Marchi
2017-01-23 22:43 ` [PATCH 1/5] Introduce specialized versions of gdbpy_ref Simon Marchi
2017-01-24 15:54 ` Tom Tromey
2017-01-24 16:18 ` Simon Marchi [this message]
2017-02-09 11:58 ` Pedro Alves
2017-02-09 16:18 ` Simon Marchi
2017-01-23 22:43 ` [PATCH 2/5] Add Python Inferior object debug traces Simon Marchi
2017-01-23 22:43 ` [PATCH 5/5] Add missing incref when creating Inferior Python object Simon Marchi
2017-02-25 18:41 ` Simon Marchi
2017-04-27 21:13 ` [pushed master+8.0] " Simon Marchi
2017-01-23 22:43 ` [PATCH 3/5] Make Python inferior-related internal functions return inferior_object* Simon Marchi
2017-01-24 0:03 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c32835f19e288ddde9a51e51b5377e18@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox