From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84556 invoked by alias); 24 Jan 2017 16:18:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84541 invoked by uid 89); 24 Jan 2017 16:18:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.5 required=5.0 tests=AWL,BAYES_20,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=msg00277.html, msg00277html, tromey, UD:msg00277.html X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Jan 2017 16:18:04 +0000 Received: by simark.ca (Postfix, from userid 33) id B2F931E166; Tue, 24 Jan 2017 11:18:02 -0500 (EST) To: Tom Tromey Subject: Re: [PATCH 1/5] Introduce specialized versions of gdbpy_ref X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 24 Jan 2017 16:18:00 -0000 From: Simon Marchi Cc: Simon Marchi , gdb-patches@sourceware.org In-Reply-To: <8737g85u9h.fsf@tromey.com> References: <20170123224004.8893-1-simon.marchi@ericsson.com> <20170123224004.8893-2-simon.marchi@ericsson.com> <8737g85u9h.fsf@tromey.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.3 X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00499.txt.bz2 On 2017-01-24 10:53, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> We currently have a single type, gdbpy_ref, which holds a > Simon> reference to a PyObject*. This means that if we want to wrap an > Simon> inferior_object* (which is a sub-class-ish of PyObject), we need > to cast > Simon> it when constructing the reference: > > This was the subject of this patch: > > https://sourceware.org/ml/gdb-patches/2017-01/msg00277.html > > I applied it all over the Python layer. > > Tom Ah damn, shame on me for missing it. At least doing it by myself made me learn a lot :). I'll take a look at that series. There might still be some bits relevant in the current series, like the bug fix in patch 5 (unless you also addressed it). I'll re-evaluate it once your series is in. Simon