From: Luis Machado <lgustavo@codesourcery.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>,
<qiyaoltc@gmail.com>
Subject: Re: [PATCH v2] Fixup gdb.python/py-value.exp for bare-metal aarch64-elf
Date: Wed, 12 Oct 2016 15:13:00 -0000 [thread overview]
Message-ID: <c264a90e-cef8-550a-55f6-d861b12484e6@codesourcery.com> (raw)
In-Reply-To: <58e6d8d5-06db-4a63-99f0-ce1e5a71fd2d@redhat.com>
On 10/12/2016 08:31 AM, Pedro Alves wrote:
> On 10/11/2016 09:55 PM, Luis Machado wrote:
>> + set argc_value [get_integer_valueof "argc" 0]
>> gdb_test "python argc_lazy = gdb.parse_and_eval('argc')"
>> gdb_test "python argc_notlazy = gdb.parse_and_eval('argc')"
>> gdb_test "python argc_notlazy.fetch_lazy()"
>> gdb_test "python print (argc_lazy.is_lazy)" "True"
>> gdb_test "python print (argc_notlazy.is_lazy)" "False"
>> - gdb_test "print argc" " = 1" "sanity check argc"
>> + gdb_test "print argc" " = $argc_value" "sanity check argc"
>> gdb_test "python print (argc_lazy.is_lazy)" "\r\nTrue"
>> gdb_test_no_output "set argc=2"
>
> Pedantically, $argc_value could be 2, so this would be better
> something like
>
> gdb_test_no_output "set argc=[expr $argc_value + 1]" "change argc"
>
>> - gdb_test "python print (argc_notlazy)" "\r\n1"
>> + gdb_test "python print (argc_notlazy)" "\r\n$argc_value"
>
>
>> gdb_test "python print (argc_lazy)" "\r\n2"
>
> Likewise.
>
Alright. I've addressed this and checked it in on master as
4dac951e11030b43b17f52df8bdfa7432e4bf73c.
Thanks Yao and Pedro.
prev parent reply other threads:[~2016-10-12 15:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 20:55 Luis Machado
2016-10-12 13:26 ` Yao Qi
2016-10-12 13:31 ` Pedro Alves
2016-10-12 15:13 ` Luis Machado [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c264a90e-cef8-550a-55f6-d861b12484e6@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox