From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-133908-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 34468 invoked by alias); 12 Oct 2016 15:13:37 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 34443 invoked by uid 89); 12 Oct 2016 15:13:35 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: relay1.mentorg.com
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Oct 2016 15:13:33 +0000
Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203])	by relay1.mentorg.com with esmtp 	id 1buLDo-0006FK-53 from Luis_Gustavo@mentor.com ; Wed, 12 Oct 2016 08:13:32 -0700
Received: from [172.30.8.195] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 12 Oct 2016 08:13:28 -0700
Reply-To: Luis Machado <lgustavo@codesourcery.com>
Subject: Re: [PATCH v2] Fixup gdb.python/py-value.exp for bare-metal aarch64-elf
References: <1476219321-10659-1-git-send-email-lgustavo@codesourcery.com> <58e6d8d5-06db-4a63-99f0-ce1e5a71fd2d@redhat.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>,	<qiyaoltc@gmail.com>
From: Luis Machado <lgustavo@codesourcery.com>
Message-ID: <c264a90e-cef8-550a-55f6-d861b12484e6@codesourcery.com>
Date: Wed, 12 Oct 2016 15:13:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <58e6d8d5-06db-4a63-99f0-ce1e5a71fd2d@redhat.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: svr-orw-mbx-01.mgc.mentorg.com (147.34.90.201) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203)
X-IsSubscribed: yes
X-SW-Source: 2016-10/txt/msg00319.txt.bz2

On 10/12/2016 08:31 AM, Pedro Alves wrote:
> On 10/11/2016 09:55 PM, Luis Machado wrote:
>> +  set argc_value [get_integer_valueof "argc" 0]
>>    gdb_test "python argc_lazy = gdb.parse_and_eval('argc')"
>>    gdb_test "python argc_notlazy = gdb.parse_and_eval('argc')"
>>    gdb_test "python argc_notlazy.fetch_lazy()"
>>    gdb_test "python print (argc_lazy.is_lazy)" "True"
>>    gdb_test "python print (argc_notlazy.is_lazy)" "False"
>> -  gdb_test "print argc" " = 1" "sanity check argc"
>> +  gdb_test "print argc" " = $argc_value" "sanity check argc"
>>    gdb_test "python print (argc_lazy.is_lazy)" "\r\nTrue"
>>    gdb_test_no_output "set argc=2"
>
> Pedantically, $argc_value could be 2, so this would be better
> something like
>
>    gdb_test_no_output "set argc=[expr $argc_value + 1]" "change argc"
>
>> -  gdb_test "python print (argc_notlazy)" "\r\n1"
>> +  gdb_test "python print (argc_notlazy)" "\r\n$argc_value"
>
>
>>    gdb_test "python print (argc_lazy)" "\r\n2"
>
> Likewise.
>

Alright. I've addressed this and checked it in on master as 
4dac951e11030b43b17f52df8bdfa7432e4bf73c.

Thanks Yao and Pedro.