From: Cary Coutant <ccoutant@google.com>
To: Doug Evans <dje@google.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [RFC] better dwarf checking for values on the stack
Date: Tue, 15 Sep 2009 20:47:00 -0000 [thread overview]
Message-ID: <c17be2b30909151347l3c7308dbha16c3cb4cf261426@mail.gmail.com> (raw)
In-Reply-To: <e394668d0909151336t12d16987u823cad7877fc99f1@mail.gmail.com>
> Yeah, if we wanted to catch more cases of what's on the stack than
> what's currently there does, then we need to appropriately handle the
> math. I explicitly left that for another day.
>
> dwarf2expr.c:
>
> /* Assume the value is not in stack memory.
> Code that knows otherwise sets this to 1.
> Some arithmetic on stack addresses can probably be assumed to
> still
> be a stack address, but we skip this complication for now.
> This is just an optimization, so it's always ok to punt
> and leave this as 0. */
> int in_stack_memory = 0;
>
> Sound ok?
Sure.
-cary
prev parent reply other threads:[~2009-09-15 20:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-10 23:21 Doug Evans
2009-09-11 18:48 ` Tom Tromey
2009-09-11 21:19 ` Doug Evans
2009-09-11 23:23 ` Doug Evans
2009-09-12 0:40 ` Doug Evans
2009-09-14 17:54 ` Tom Tromey
2009-09-14 23:04 ` Doug Evans
2009-09-15 16:05 ` Tom Tromey
2009-09-15 16:10 ` Joel Brobecker
2009-09-15 16:22 ` Doug Evans
2009-09-15 20:20 ` Cary Coutant
2009-09-15 20:36 ` Doug Evans
2009-09-15 20:47 ` Cary Coutant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c17be2b30909151347l3c7308dbha16c3cb4cf261426@mail.gmail.com \
--to=ccoutant@google.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox