From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-66896-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6218 invoked by alias); 15 Sep 2009 20:47:35 -0000
Received: (qmail 6203 invoked by uid 22791); 15 Sep 2009 20:47:34 -0000
X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Sep 2009 20:47:32 +0000
Received: from wpaz5.hot.corp.google.com (wpaz5.hot.corp.google.com [172.24.198.69]) 	by smtp-out.google.com with ESMTP id n8FKlU1S023139 	for <gdb-patches@sourceware.org>; Tue, 15 Sep 2009 13:47:30 -0700
Received: from pxi8 (pxi8.prod.google.com [10.243.27.8]) 	by wpaz5.hot.corp.google.com with ESMTP id n8FKjO5V020654 	for <gdb-patches@sourceware.org>; Tue, 15 Sep 2009 13:47:27 -0700
Received: by pxi8 with SMTP id 8so3797731pxi.27         for <gdb-patches@sourceware.org>; Tue, 15 Sep 2009 13:47:27 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.143.27.41 with SMTP id e41mr590468wfj.218.1253047646638; Tue,  	15 Sep 2009 13:47:26 -0700 (PDT)
In-Reply-To: <e394668d0909151336t12d16987u823cad7877fc99f1@mail.gmail.com>
References: <20090910231912.0733A843B9@localhost> 	 <m3d45xgvx9.fsf@fleche.redhat.com> 	 <e394668d0909111419q34f4848dhf5e3fde307b274a8@mail.gmail.com> 	 <e394668d0909111623o5f78ede7t5041bdb5052481ba@mail.gmail.com> 	 <m3fxap8lai.fsf@fleche.redhat.com> 	 <e394668d0909141604h4ca3d193o3f3113f209aea851@mail.gmail.com> 	 <c17be2b30909151320l7a4a5a0cnd7857e965249620a@mail.gmail.com> 	 <e394668d0909151336t12d16987u823cad7877fc99f1@mail.gmail.com>
Date: Tue, 15 Sep 2009 20:47:00 -0000
Message-ID: <c17be2b30909151347l3c7308dbha16c3cb4cf261426@mail.gmail.com>
Subject: Re: [RFC] better dwarf checking for values on the stack
From: Cary Coutant <ccoutant@google.com>
To: Doug Evans <dje@google.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-System-Of-Record: true
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-09/txt/msg00491.txt.bz2

> Yeah, if we wanted to catch more cases of what's on the stack than
> what's currently there does, then we need to appropriately handle the
> math. =A0I explicitly left that for another day.
>
> dwarf2expr.c:
>
> =A0 =A0 =A0/* Assume the value is not in stack memory.
> =A0 =A0 =A0 =A0 Code that knows otherwise sets this to 1.
> =A0 =A0 =A0 =A0 Some arithmetic on stack addresses can probably be assume=
d to
> still
> =A0 =A0 =A0 =A0 be a stack address, but we skip this complication for now.
> =A0 =A0 =A0 =A0 This is just an optimization, so it's always ok to punt
> =A0 =A0 =A0 =A0 and leave this as 0. =A0*/
> =A0 =A0 =A0int in_stack_memory =3D 0;
>
> Sound ok?

Sure.

-cary