Re: [PATCH] gdb: fix 32 bit build

[Guinevere Larsen <guinevere@redhat.com>]

On 4/24/25 10:21 AM, Luis Machado wrote:
> On 4/24/25 12:48, Guinevere Larsen wrote:
>> On 4/24/25 8:47 AM, Guinevere Larsen wrote:
>>> The recent commit dbbb9cfd3708a5b09b449c6cbc4d74dfec13904d added a
>>> message using %ld to print an std::vector::size, which is of size_t
>>> type. on 64 bit machines, size_t will be an unsigned long int, making
>>> %ld work just fine, but on 32 bit ones, size_t will be unsigned int,
>>> which causes build to fail.
> Pedantically...
>
> s/build/the build
>
>>> This commit fixes that by using %zu instead.
>> After sending the email I realized I forgot the bug trailer. I'll add
>>
>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32901
>>
>> locally
>>
>>> ---
>>>    gdb/solib.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/gdb/solib.c b/gdb/solib.c
>>> index 5c5cfbdd9b9..85ec6bb2f1e 100644
>>> --- a/gdb/solib.c
>>> +++ b/gdb/solib.c
>>> @@ -1230,7 +1230,7 @@ info_linker_namespace_command (const char *pattern, int from_tty)
>>>          break;
>>>        }
>>>          uiout->message
>>> -    (_ ("There are %ld libraries loaded in linker namespace [[%d]]\n"),
>>> +    (_ ("There are %zu libraries loaded in linker namespace [[%d]]\n"),
>>>         solibs_to_print.size (), ns);
>>>          uiout->message
>>>        (_ ("Displaying libraries for linker namespace [[%d]]:\n"), ns);
>>>
>>> base-commit: 8c8e5b1f1abfbce913783da0f1cd1f85c60bd445
>>
> Thanks for the quick patch. This is OK.
>
> Tested-By: Luis Machado <luis.machado@arm.com>
> Approved-By: Luis Machado <luis.machado@arm.com>
>
thanks for the quick review, I've pushed the patch!

-- 
Cheers,
Guinevere Larsen
She/Her/Hers