From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id siOwJB6ICmiptAMAWB0awg (envelope-from ) for ; Thu, 24 Apr 2025 14:51:10 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TIY+NlfT; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8BA9F1E0C3; Thu, 24 Apr 2025 14:51:10 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 365E91E089 for ; Thu, 24 Apr 2025 14:51:09 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B7E603858C42 for ; Thu, 24 Apr 2025 18:51:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B7E603858C42 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TIY+NlfT Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id ED7F83858D35 for ; Thu, 24 Apr 2025 18:50:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ED7F83858D35 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ED7F83858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745520607; cv=none; b=ny8CwgyyEr4KegCppP3+GzI3jg49OTIncLOddmiM6lqMtbnWFt0zwDFBcFflKSQTMHImVS1Gq72PvmwRWo1K0VyfIxFIU7f7UwqDL7RsP2mxnnGfDi+GpicSpgWeaX43IhRKK1MrhYtfIFgMS8Ho7zBx232eX6OF8PMQbx+vtGY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745520607; c=relaxed/simple; bh=iNaOs8yNjvU9+RusFLlVN/Y1XHMDR8qGLxP+kcfKDJ8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=qesDaKnexntzgGx6ED2/dxtCmN8U3dFkKFJ8JhSoyxfmdr9CtP9Md92vWQqB9EtRC0WI6sqLiiJtzioFF14LtAzfzxv0st/cnfm/Z7g5LMePY+wM6dAXYG7fYMnH9VDRm3k+wRm55wX2UnPWUGLg65iPGMu8qBoBpnPmjUQ0fYA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ED7F83858D35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745520606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RVCXP03tXbT0ho6IwXvMNWfz+uSKFxvXFrx3H3NLcRA=; b=TIY+NlfTgnsF3jvoV088krAYLfcPdM74MOsCYOXe25FQhd0ss2+9jn+TITbZSH21KnblEB e6FNouvJ3lAsE0gpIiJ10HA79RqYn/shXbVRmJG0d/pqK4i41x7GqUMqDr/5Id9BfYGosA xkEg+IvzSmfTHZpiSlmoy4hGuHE/U34= Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-154-4VI6nFdwPFSvRDd-Gva1Nw-1; Thu, 24 Apr 2025 14:50:05 -0400 X-MC-Unique: 4VI6nFdwPFSvRDd-Gva1Nw-1 X-Mimecast-MFC-AGG-ID: 4VI6nFdwPFSvRDd-Gva1Nw_1745520604 Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-736d64c5e16so1094472b3a.3 for ; Thu, 24 Apr 2025 11:50:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745520604; x=1746125404; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RVCXP03tXbT0ho6IwXvMNWfz+uSKFxvXFrx3H3NLcRA=; b=NGyHRMkMhepWxKDddr6rUdlMdXC6iA4gx6u0D2liQ2HKIZ03nxr/Gp/uuphVUVtUt3 ot3E3DBhV/1jEESOx6u4BuELY4ohtESieqKH436JVnBDMWyxHsRGDqcwepGW2dHivjha PSXrC+Ta2soNPsc42VCnkq7Xr9VcFUIk4tQ3Sg4OwgJBmvrImxSy6tBbYxhJrauk0BxN kJ7lm+Aq+gjn419TCeCV7XpRrLUuB3zNuRnYA8/RJlDBD9sdCA3RMn0TpJg2m/ezUEEk fhM7Tc+T3TuKREN5v4oBmKso4ugUJLjL4pIYz5sZGCwAkJdGcEaoOpIzj+bcLiFL4tBV FOxw== X-Forwarded-Encrypted: i=1; AJvYcCXKOHqLSy/2AIntTxBJy2SY+/QOTmBEfFDbL8i1Tq2Yue0EiEiUu/rgPurAWJvyzQ2oBT37sWr3pMJX1g==@sourceware.org X-Gm-Message-State: AOJu0YzgUK6k4LOuJ8MXGHN/4fh/r0dptff0PvCGavgq1dzyQnqGYYf4 5sGjGDGwGyeWBopTI815lSwT1jU8Ghp2nHtZPMCzzF1e0Bf+C/btxI8RRkxAU98nNrbdR3cmcne V6sY7nyyIZyrcilC33Wf30mHo8VzugX6undEHALBtN7gsNNDPGA8tMSZThm71OVyxJrw= X-Gm-Gg: ASbGncteeXLB15OLv/ukulkys64GIkk+UuSIxe+vxswQBlLn1eYgXl06mimVbgzad8M lwDVgJHT/dwxR7z3TKAZx9RRZ6lWsxkvQh0GETu0q4L+5Y85YFtXB2PK14I1C3RDl4yCL4YE9v9 sgZL8F6GYm0w+uKjEhPZoHY2a2X4LD3IHoY30U07sWvg1qxrqLUuns1Wxc/qs7h854O29vRm9Da 04x1ht84vG6aFiXnxPkEN8cB83FRNDJuakh3N/5w6r45NW2C0s/SCRF8a4kafXhleUVrIVncrgf TCI760cpALDoq6M8+adJ814= X-Received: by 2002:a05:6a00:2e0f:b0:73e:30dd:d14b with SMTP id d2e1a72fcca58-73e330dbf96mr932510b3a.15.1745520604148; Thu, 24 Apr 2025 11:50:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHId3IWXKBWc+iXSs/rbCMnEDAU5BL8KJF88eCrsF/p46CTYpOAe6shFb5j39CCQwjRHFfTRw== X-Received: by 2002:a05:6a00:2e0f:b0:73e:30dd:d14b with SMTP id d2e1a72fcca58-73e330dbf96mr932484b3a.15.1745520603818; Thu, 24 Apr 2025 11:50:03 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:9a69::1001? ([2804:14d:8084:9a69::1001]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e259414d3sm1750288b3a.47.2025.04.24.11.50.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Apr 2025 11:50:03 -0700 (PDT) Message-ID: Date: Thu, 24 Apr 2025 15:50:00 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: fix 32 bit build To: Luis Machado , gdb-patches@sourceware.org References: <20250424114743.1776473-1-guinevere@redhat.com> <4ddb13a5-00cf-48fd-ab53-39a5f837beb6@arm.com> From: Guinevere Larsen In-Reply-To: <4ddb13a5-00cf-48fd-ab53-39a5f837beb6@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: lt4k_OU1PrkQXAt6p-bIFCDzJhK4LeShCxXjB1QAkK4_1745520604 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/24/25 10:21 AM, Luis Machado wrote: > On 4/24/25 12:48, Guinevere Larsen wrote: >> On 4/24/25 8:47 AM, Guinevere Larsen wrote: >>> The recent commit dbbb9cfd3708a5b09b449c6cbc4d74dfec13904d added a >>> message using %ld to print an std::vector::size, which is of size_t >>> type. on 64 bit machines, size_t will be an unsigned long int, making >>> %ld work just fine, but on 32 bit ones, size_t will be unsigned int, >>> which causes build to fail. > Pedantically... > > s/build/the build > >>> This commit fixes that by using %zu instead. >> After sending the email I realized I forgot the bug trailer. I'll add >> >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32901 >> >> locally >> >>> --- >>>   gdb/solib.c | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/gdb/solib.c b/gdb/solib.c >>> index 5c5cfbdd9b9..85ec6bb2f1e 100644 >>> --- a/gdb/solib.c >>> +++ b/gdb/solib.c >>> @@ -1230,7 +1230,7 @@ info_linker_namespace_command (const char *pattern, int from_tty) >>>         break; >>>       } >>>         uiout->message >>> -    (_ ("There are %ld libraries loaded in linker namespace [[%d]]\n"), >>> +    (_ ("There are %zu libraries loaded in linker namespace [[%d]]\n"), >>>        solibs_to_print.size (), ns); >>>         uiout->message >>>       (_ ("Displaying libraries for linker namespace [[%d]]:\n"), ns); >>> >>> base-commit: 8c8e5b1f1abfbce913783da0f1cd1f85c60bd445 >> > Thanks for the quick patch. This is OK. > > Tested-By: Luis Machado > Approved-By: Luis Machado > thanks for the quick review, I've pushed the patch! -- Cheers, Guinevere Larsen She/Her/Hers