Re: [PATCH v2] Search for DWZ files in debug-file-directories as well

[Simon Marchi <simark@simark.ca>]

On 2020-11-28 3:58 p.m., Sergio Durigan Junior wrote:
>> I think it would be more readable and efficient (less bytes copied
>> around) to do just build the new_filename string with something like:
>>
>>   std::string new_filename = debugdir + &filename[dwz_pos];
>>
>> This is untested, but I think you'll get the point.  &filename[dwz_pos]
>> could also be put into a variable with a meaningful name, for clarity
>> (though I can't think of a good name right now).
>
> It is more efficient, but using .erase + .insert can be more readable.
> But OK, I don't have a strong opinion here.

Well, I suggested the other way because I think that is more readable
:).  I see it more as "the new path is made of this part plus that
part".  I'll let you choose what you prefer, it's not code that needs to
be extremely optimized anyway.

>> And we probably don't need the allocated `ddir` std::string, you
>> construct it but never really use it (you could just refer to debugdir).
>
> I'll need it for the new version of the code, which will implement the
> idea I gave above (always guaranteeing that ddir ends with
> DIR_SEPARATOR).

Ok, if you do that I think you can move ddir out of the loop, it doesn't
need to be re-computed for each loop iteration.

Simon