From: Sergio Durigan Junior via Gdb-patches <gdb-patches@sourceware.org>
To: Simon Marchi <simark@simark.ca>
Cc: Mark Wielaard <mark@klomp.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Search for DWZ files in debug-file-directories as well
Date: Sat, 28 Nov 2020 19:57:43 -0500 [thread overview]
Message-ID: <87r1odyo6w.fsf@paluero> (raw)
In-Reply-To: <bfeb19d9-ce0f-7960-c78f-46dccb2cb863@simark.ca> (Simon Marchi's message of "Sat, 28 Nov 2020 17:12:21 -0500")
On Saturday, November 28 2020, Simon Marchi wrote:
> On 2020-11-28 3:58 p.m., Sergio Durigan Junior wrote:
>>> And we probably don't need the allocated `ddir` std::string, you
>>> construct it but never really use it (you could just refer to debugdir).
>>
>> I'll need it for the new version of the code, which will implement the
>> idea I gave above (always guaranteeing that ddir ends with
>> DIR_SEPARATOR).
>
> Ok, if you do that I think you can move ddir out of the loop, it doesn't
> need to be re-computed for each loop iteration.
ddir is just a temporary variable that will hold the current
debug-file-directory + SLASH_STRING. I don't see how I could
pre-compute it outside the loop, where I won't have access to the
debug-file-directory. But maybe I'm missing something?
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
https://sergiodj.net/
next prev parent reply other threads:[~2020-11-29 0:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 23:48 [PATCH] " Sergio Durigan Junior via Gdb-patches
2020-11-15 13:19 ` Mark Wielaard
2020-11-16 1:25 ` Simon Marchi
2020-11-16 9:32 ` Mark Wielaard
2020-11-16 17:57 ` Sergio Durigan Junior via Gdb-patches
2020-11-19 2:27 ` [PATCH v2] " Sergio Durigan Junior via Gdb-patches
2020-11-25 15:09 ` Sergio Durigan Junior via Gdb-patches
2020-11-25 16:58 ` Luis Machado via Gdb-patches
2020-11-28 20:51 ` Sergio Durigan Junior via Gdb-patches
2020-11-26 16:53 ` Simon Marchi
2020-11-28 20:58 ` Sergio Durigan Junior via Gdb-patches
2020-11-28 21:35 ` Sergio Durigan Junior via Gdb-patches
2020-11-28 22:13 ` Simon Marchi
2020-11-28 22:12 ` Simon Marchi
2020-11-29 0:57 ` Sergio Durigan Junior via Gdb-patches [this message]
2020-11-29 1:29 ` Simon Marchi
2020-11-29 1:08 ` [PATCH v3] " Sergio Durigan Junior via Gdb-patches
2020-12-01 14:45 ` Simon Marchi
2020-12-02 3:08 ` Sergio Durigan Junior via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1odyo6w.fsf@paluero \
--to=gdb-patches@sourceware.org \
--cc=mark@klomp.org \
--cc=sergiodj@sergiodj.net \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox