Re: Obsolete/remove Solaris < 10 [was: Re: Fix gdb 8.1 Solaris compilation]

[Pedro Alves <palves@redhat.com>]

On 09/22/2017 03:44 PM, Rainer Orth wrote:
>> On 09/21/2017 03:30 PM, Rainer Orth wrote:
> 
>> all these years stepped forward, I think we should be able to just drop
>> it.  I think you've proposed this in the past, even.  I very
> 
> Indeed: I found a line or two of notes about it.  Must have been in the
> context of removing support for unstructured /proc in procfs.c and
> friends.  I've dusted off and completed that patch as well...

Yay, looking forward to that.  :-)

>> much doubt anyone would step forward this time.
> 
> Indeed.  I've opened a tracking PR gdb/22185 and produced a first patch.
> It will need a bit more testing (especially on Linux which also uses
> proc-service.c), but it's basically straightforward.

Eh, the Solaris port doesn't actually use proc-service.c.   The
Solaris proc-service implementation is directly in sol-thread.c.
I think proc-service.c was originally based on sol-thread.c, maybe
aiming at sharing at some point, and that's where it got the
PROC_SERVICE_IS_OLD handling from.

The patch looks good to me.

I mildly wonder if the adding of sol-thread.o could move
from gdb/configure.ac to gdb/configure.nat.

Thanks,
Pedro Alves